refactor: atomic, DRY, and logging improvements across codebase

- Split llmModerationClient.ts (2170 lines) into 5 focused sub-modules
- Split aiAnalyzer.ts (1282 lines) into 4 modular pipelines
- Split messages.db.ts (826 lines) into 5 domain-specific modules
- Moved shared schema to @bete/shared, eliminated backend duplication
- Added createChildLogger to all voice-recording and AI moderation modules
- Extracted tryCommandThenFallback, normalizeMediaState, DEFAULT_VOICE_STATUS
- Created shared pagination.ts utility, eliminated 5+ cursor-pagination duplications
- Created shared messageMapper.ts for row mapping
- Standardized backend error handling with asyncHandler
- Added frontend createLogger utility and useAsyncAction hook
- Added structured logging to frontend hooks, socket, and API client

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

services/backend/src/modules/voice/voice.service.ts

@@ -6,7 +6,10 @@ import {
   COMMAND_VOICE_DISCONNECT,
   VOICE_STATUS_KEY,
 } from "@bete/shared";
-import { createChildLogger } from "@bete/shared/logger";
+import {
+  createChildLogger,
+  tryCommandThenFallback,
+} from "../../shared/commandHelper.js";
 import { getPool } from "../../shared/database/index.js";
 import { publishCommand, readRedisStatus } from "../../shared/redis/index.js";
 
@@ -31,29 +34,40 @@ export interface VoiceStatus {
   activeChannelName: string | null;
 }
 
+export const DEFAULT_VOICE_STATUS: VoiceStatus = {
+  connected: false,
+  activeGuildId: null,
+  activeChannelId: null,
+  activeChannelName: null,
+};
+
+function readVoiceStatusFallback(): Promise<VoiceStatus> {
+  return readRedisStatus(VOICE_STATUS_KEY).then(
+    (cached) => (cached as unknown as VoiceStatus) ?? DEFAULT_VOICE_STATUS,
+  );
+}
+
 /**
  * Get guilds — query from discord-gateway via Redis command for real names.
  * Falls back to database (distinct guild_id from messages) if gateway unreachable.
  */
 export async function getGuilds(): Promise<Guild[]> {
   logger.info("getGuilds called");
-  const reply = await publishCommand<Guild[]>(COMMAND_GUILDS_LIST, {});
-  if (reply?.success && reply.data && reply.data.length > 0) return reply.data;
-
-  // Fallback: Postgres with synthetic names
-  logger.warn(
-    "discord-gateway unreachable, falling back to Postgres for guilds",
+  return tryCommandThenFallback(
+    () => publishCommand<Guild[]>(COMMAND_GUILDS_LIST, {}),
+    async () => {
+      const pool = getPool();
+      const { rows } = await pool.query(
+        `SELECT DISTINCT guild_id FROM messages ORDER BY guild_id`,
+      );
+      return rows.map((row: Record<string, unknown>) => ({
+        id: String(row.guild_id ?? ""),
+        name: `Guild ${String(row.guild_id).slice(0, 8)}`,
+        icon: null,
+      }));
+    },
+    "getGuilds",
   );
-  const pool = getPool();
-  const { rows } = await pool.query(
-    `SELECT DISTINCT guild_id FROM messages ORDER BY guild_id`,
-  );
-
-  return rows.map((row: Record<string, unknown>) => ({
-    id: String(row.guild_id ?? ""),
-    name: `Guild ${String(row.guild_id).slice(0, 8)}`,
-    icon: null,
-  }));
 }
 
 /**
@@ -62,27 +76,22 @@ export async function getGuilds(): Promise<Guild[]> {
  */
 export async function getTextChannels(guildId: string): Promise<Channel[]> {
   logger.info({ guildId }, "getTextChannels called");
-  const reply = await publishCommand<Channel[]>(COMMAND_GUILDS_TEXT_CHANNELS, {
-    guildId,
-  });
-  if (reply?.success && reply.data && reply.data.length > 0) return reply.data;
-
-  // Fallback: Postgres with synthetic names
-  logger.warn(
-    { guildId },
-    "discord-gateway unreachable, falling back to Postgres for text channels",
+  return tryCommandThenFallback(
+    () => publishCommand<Channel[]>(COMMAND_GUILDS_TEXT_CHANNELS, { guildId }),
+    async () => {
+      const pool = getPool();
+      const { rows } = await pool.query(
+        `SELECT DISTINCT channel_id FROM messages WHERE guild_id = $1 ORDER BY channel_id`,
+        [guildId],
+      );
+      return rows.map((row: Record<string, unknown>) => ({
+        id: String(row.channel_id ?? ""),
+        name: `Channel ${String(row.channel_id).slice(0, 8)}`,
+        type: "text" as const,
+      }));
+    },
+    "getTextChannels",
   );
-  const pool = getPool();
-  const { rows } = await pool.query(
-    `SELECT DISTINCT channel_id FROM messages WHERE guild_id = $1 ORDER BY channel_id`,
-    [guildId],
-  );
-
-  return rows.map((row: Record<string, unknown>) => ({
-    id: String(row.channel_id ?? ""),
-    name: `Channel ${String(row.channel_id).slice(0, 8)}`,
-    type: "text" as const,
-  }));
 }
 
 /**
@@ -102,13 +111,7 @@ export async function getVoiceChannels(guildId: string): Promise<Channel[]> {
 export async function getVoiceStatus(): Promise<VoiceStatus> {
   logger.debug("getVoiceStatus called");
   const cached = await readRedisStatus(VOICE_STATUS_KEY);
-  if (cached) return cached as unknown as VoiceStatus;
-  return {
-    connected: false,
-    activeGuildId: null,
-    activeChannelId: null,
-    activeChannelName: null,
-  };
+  return (cached as unknown as VoiceStatus) ?? DEFAULT_VOICE_STATUS;
 }
 
 /**
@@ -119,21 +122,14 @@ export async function connectVoice(
   channelId: string,
 ): Promise<VoiceStatus> {
   logger.info({ guildId, channelId }, "connectVoice called");
-  const reply = await publishCommand<VoiceStatus>(COMMAND_VOICE_CONNECT, {
-    guildId,
-    channelId,
-  });
-  if (reply?.success && reply.data) return reply.data;
-
-  // Fallback: read from Redis status key
-  const cached = await readRedisStatus(VOICE_STATUS_KEY);
-  return (
-    (cached as unknown as VoiceStatus) ?? {
-      connected: false,
-      activeGuildId: null,
-      activeChannelId: null,
-      activeChannelName: null,
-    }
+  return tryCommandThenFallback(
+    () =>
+      publishCommand<VoiceStatus>(COMMAND_VOICE_CONNECT, {
+        guildId,
+        channelId,
+      }),
+    () => readVoiceStatusFallback(),
+    "connectVoice",
   );
 }
 
@@ -142,16 +138,9 @@ export async function connectVoice(
  */
 export async function disconnectVoice(): Promise<VoiceStatus> {
   logger.info("disconnectVoice called");
-  const reply = await publishCommand<VoiceStatus>(COMMAND_VOICE_DISCONNECT, {});
-  if (reply?.success && reply.data) return reply.data;
-
-  const cached = await readRedisStatus(VOICE_STATUS_KEY);
-  return (
-    (cached as unknown as VoiceStatus) ?? {
-      connected: false,
-      activeGuildId: null,
-      activeChannelId: null,
-      activeChannelName: null,
-    }
+  return tryCommandThenFallback(
+    () => publishCommand<VoiceStatus>(COMMAND_VOICE_DISCONNECT, {}),
+    () => readVoiceStatusFallback(),
+    "disconnectVoice",
   );
 }