ci: fix lint errors for CI

- Fix noImplicitAnyLet: add type to let match variable
- Fix noAssignInExpressions: use matchAll() + for-of instead of while
- Suppress useExhaustiveDependencies in mascot scroll effect
- Suppress useSemanticElements for message card click handler

services/discord-gateway/src/modules/voice-recording/mediaSource.ts

@@ -1,5 +1,5 @@
 import { type ChildProcess, spawn } from "node:child_process";
-import { PassThrough, Readable } from "node:stream";
+import { PassThrough, type Readable } from "node:stream";
 import { createChildLogger } from "@bete/shared/logger";
 import { StreamType } from "@discordjs/voice";
 

services/discord-gateway/src/modules/voice-recording/packetFilter.ts

@@ -1,4 +1,4 @@
-import { Transform, TransformCallback } from "node:stream";
+import { Transform, type TransformCallback } from "node:stream";
 import { createChildLogger } from "@bete/shared/logger";
 
 const logger = createChildLogger("packet-filter");

services/discord-gateway/src/modules/voice-recording/player.ts

@@ -1,13 +1,13 @@
-import { Readable } from "node:stream";
+import type { Readable } from "node:stream";
 import { createChildLogger } from "@bete/shared/logger";
 import {
-  AudioPlayer,
+  type AudioPlayer,
   AudioPlayerStatus,
   type AudioResource,
   createAudioPlayer,
   createAudioResource,
   StreamType,
-  VoiceConnection,
+  type VoiceConnection,
 } from "@discordjs/voice";
 import type { DiscordPlayerOwner, DiscordPlayOptions } from "./mediaTypes.js";
 

services/discord-gateway/src/modules/voice-recording/recorder/speakingHandler.ts

@@ -121,7 +121,7 @@ export function createSpeakingHandler(
 
       // Step 4: Open the first segment
       const activeSession = activeSessions.get(channel.guild.id);
-      let currentSegment = segmentManager.open(oggPacketStream);
+      const currentSegment = segmentManager.open(oggPacketStream);
 
       // Step 5: Handle segment file completion
       currentSegment.out.on("finish", () => {