Files
TeleUploader/src/utils/s3/object-stream.ts
T
Claude de7d276245
Deploy FileDrop / deploy (push) Successful in 43s
fix: round 2 S3 audit — CRITICAL SigV4 payload hash bug, timeouts, Content-MD5/Length validation
CRITICAL:
- SigV4 canonical request used sha256Hex('') instead of x-amz-content-sha256
  header value — every PUT/POST with body would fail 403. Now uses the
  signed header value for canonical request, verifyBodyHash after streaming
  for integrity.

HIGH:
- Add 30s AbortSignal.timeout to all Telegram CDN fetches in object-stream.ts
  (previously could hang indefinitely, exhausting connection pool)

MEDIUM:
- Content-MD5 validation: compute and compare when header is present
- Content-Length validation: reject if actual body size != header
- max-keys=0 clamping: enforce minimum of 1 per S3 spec

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-07-29 08:22:45 +07:00

134 lines
4.4 KiB
TypeScript

import { gunzipSync } from 'node:zlib';
import { applyS3Headers } from './headers';
import { contentRange, type RangeParseResult } from './range';
export interface ObjectPartSource {
telegramFileId: string;
telegramUrl: string;
sizeBytes: number;
partNumber: number;
storedSizeBytes?: number;
compressionAlgorithm?: 'gzip' | null;
}
export interface ObjectResponseInput {
reqId: string;
contentType: string;
etag: string;
lastModified: Date;
totalSize: number;
parts: ObjectPartSource[];
range: RangeParseResult;
}
interface PlannedPart {
part: ObjectPartSource;
relativeStart: number;
relativeEnd: number;
}
const baseHeaders = (input: ObjectResponseInput, contentLength: number): Headers => {
const headers = new Headers({
'content-type': input.contentType,
'content-length': String(contentLength),
etag: `"${input.etag}"`,
'last-modified': input.lastModified.toUTCString(),
'x-amz-request-id': input.reqId,
'accept-ranges': 'bytes',
'cache-control': 'public, max-age=31536000',
});
return headers;
};
const planParts = (parts: ObjectPartSource[], start: number, end: number): PlannedPart[] => {
const planned: PlannedPart[] = [];
let offset = 0;
for (const part of parts) {
const partStart = offset;
const partEnd = offset + part.sizeBytes - 1;
offset += part.sizeBytes;
if (end < partStart || start > partEnd) continue;
planned.push({
part,
relativeStart: Math.max(start, partStart) - partStart,
relativeEnd: Math.min(end, partEnd) - partStart,
});
}
return planned;
};
const streamFromBytes = (bytes: Uint8Array): ReadableStream<Uint8Array> =>
new Response(bytes).body!;
const TELEGRAM_FETCH_TIMEOUT_MS = 30_000;
const fetchWholePartBytes = async (telegramUrl: string): Promise<Uint8Array> => {
const res = await fetch(telegramUrl, { signal: AbortSignal.timeout(TELEGRAM_FETCH_TIMEOUT_MS) });
if (!res.ok) throw new Error(`Telegram fetch failed: ${res.status}`);
return new Uint8Array(await res.arrayBuffer());
};
const fetchPartBody = async (planned: PlannedPart): Promise<ReadableStream<Uint8Array>> => {
const wantsWholePart =
planned.relativeStart === 0 && planned.relativeEnd === planned.part.sizeBytes - 1;
if (planned.part.compressionAlgorithm === 'gzip') {
const storedBytes = await fetchWholePartBytes(planned.part.telegramUrl);
const bytes = gunzipSync(storedBytes);
return streamFromBytes(bytes.subarray(planned.relativeStart, planned.relativeEnd + 1));
}
const rangeHeader = `bytes=${planned.relativeStart}-${planned.relativeEnd}`;
const fetchOpts: RequestInit = { signal: AbortSignal.timeout(TELEGRAM_FETCH_TIMEOUT_MS) };
if (!wantsWholePart) {
fetchOpts.headers = { range: rangeHeader };
}
const res = await fetch(planned.part.telegramUrl, fetchOpts);
if (!res.ok) throw new Error(`Telegram fetch failed: ${res.status}`);
if (wantsWholePart || res.status === 206) return res.body!;
const bytes = new Uint8Array(await res.arrayBuffer());
return streamFromBytes(bytes.slice(planned.relativeStart, planned.relativeEnd + 1));
};
const concatPartStreams = (plannedParts: PlannedPart[]): ReadableStream<Uint8Array> =>
new ReadableStream<Uint8Array>({
async start(controller) {
try {
for (const planned of plannedParts) {
const stream = await fetchPartBody(planned);
const reader = stream.getReader();
while (true) {
const { value, done } = await reader.read();
if (done) break;
if (value) controller.enqueue(value);
}
}
controller.close();
} catch (error) {
controller.error(error);
}
},
});
export const createGetObjectResponse = async (input: ObjectResponseInput): Promise<Response> => {
if (input.range.type === 'invalid') {
throw new Error('createGetObjectResponse received invalid range');
}
const start = input.range.type === 'valid' ? input.range.start : 0;
const end = input.range.type === 'valid' ? input.range.end : input.totalSize - 1;
const plannedParts = planParts(input.parts, start, end);
const contentLength = end >= start ? end - start + 1 : 0;
const headers = applyS3Headers(baseHeaders(input, contentLength), input.reqId);
if (input.range.type === 'valid') {
headers.set('content-range', contentRange(start, end, input.totalSize));
}
return new Response(concatPartStreams(plannedParts), {
status: input.range.type === 'valid' ? 206 : 200,
headers,
});
};