From abd60c607ddd6eddb60b1c74b6773fdc5e8ad3e1 Mon Sep 17 00:00:00 2001
From: asepharyana <superaseph@gmail.com>
Date: Sat, 25 Jul 2026 17:51:51 +0700
Subject: [PATCH] feat(hooks): skill injection with EXTREMELY_IMPORTANT framing

- Follow obra/superpowers pattern: <EXTREMELY_IMPORTANT> wrapper
- Clear instruction that these are loaded skills, not passive text
- 8 mandatory skill contents injected before any user interaction
- Detected skills listed for on-demand loading via Skill tool
- SessionStart hook now properly primes Claude with all rules
---
 hooks/scripts/detect-project.sh | 59 +++++++++++++++++++--------------
 1 file changed, 35 insertions(+), 24 deletions(-)

diff --git a/hooks/scripts/detect-project.sh b/hooks/scripts/detect-project.sh
index 78936a3..bd7652e 100755
--- a/hooks/scripts/detect-project.sh
+++ b/hooks/scripts/detect-project.sh
@@ -1,5 +1,5 @@
 #!/bin/bash
-# hub-guide: load best-practice skills at session start
+# hub-guide: inject best-practice skills into context at session start
 set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
@@ -7,7 +7,6 @@ PLUGIN_ROOT="$(cd "${SCRIPT_DIR}/../.." && pwd)"
 PROJECT_DIR="$(pwd)"
 SKILL_NAMES=""
 
-# Helper: check if a package.json field contains a dependency name
 has_dep() { local n="$1"; grep -q "\"$n\"" package.json 2>/dev/null; }
 
 # --- project detection ---
@@ -16,10 +15,10 @@ if [ -f "pnpm-workspace.yaml" ] || [ -f "lerna.json" ] || [ -f "nx.json" ] || [
 fi
 if [ -f "tsconfig.json" ] || [ -f "jsconfig.json" ]; then
   SKILL_NAMES="$SKILL_NAMES, typescript"
-  if has_dep "next";             then SKILL_NAMES="$SKILL_NAMES, nextjs"; fi
-  if has_dep "elysia";           then SKILL_NAMES="$SKILL_NAMES, elysiajs"; fi
-  if has_dep "hono";             then SKILL_NAMES="$SKILL_NAMES, hono-backend"; fi
-  if has_dep "drizzle-orm";      then SKILL_NAMES="$SKILL_NAMES, drizzle-database"; fi
+  if has_dep "next";        then SKILL_NAMES="$SKILL_NAMES, nextjs"; fi
+  if has_dep "elysia";      then SKILL_NAMES="$SKILL_NAMES, elysiajs"; fi
+  if has_dep "hono";        then SKILL_NAMES="$SKILL_NAMES, hono-backend"; fi
+  if has_dep "drizzle-orm"; then SKILL_NAMES="$SKILL_NAMES, drizzle-database"; fi
 fi
 if [ -f "vite.config.ts" ] || [ -f "vite.config.js" ] || has_dep "react" 2>/dev/null; then
   case "$SKILL_NAMES" in *react-frontend*) ;; *) SKILL_NAMES="$SKILL_NAMES, react-frontend" ;; esac
@@ -30,8 +29,8 @@ fi
 if [ -f "pyproject.toml" ] || [ -f "setup.py" ] || [ -f "requirements.txt" ] || [ -f "Pipfile" ] || [ -f "poetry.lock" ] || [ -f "uv.lock" ]; then
   SKILL_NAMES="$SKILL_NAMES, python"
 fi
-if [ -f "Cargo.toml" ]; then            SKILL_NAMES="$SKILL_NAMES, rust"; fi
-if [ -f "go.mod" ]; then                SKILL_NAMES="$SKILL_NAMES, go"; fi
+if [ -f "Cargo.toml" ]; then                     SKILL_NAMES="$SKILL_NAMES, rust"; fi
+if [ -f "go.mod" ]; then                         SKILL_NAMES="$SKILL_NAMES, go"; fi
 if [ -f "Dockerfile" ] || [ -f "docker-compose.yml" ] || [ -f "compose.yml" ] || ls Dockerfile.* 2>/dev/null | grep -q .; then
   SKILL_NAMES="$SKILL_NAMES, docker"
 fi
@@ -42,33 +41,45 @@ fi
 MANDATORY="engineering-principles clean-code clean-architecture testing error-handling security git-workflow api-design"
 SKILL_NAMES="${SKILL_NAMES#, }"
 
-# --- load skill content for context injection ---
-load_skill() {
+# --- read skill content ---
+read_skill() {
   local f="${PLUGIN_ROOT}/skills/${1}/SKILL.md"
-  [ -f "$f" ] && cat "$f" || echo "(skill $1 not found)"
+  [ -f "$f" ] && cat "$f" || echo ""
 }
 
-# Output summary (visible in session)
+# Summary header (visible in session)
 echo "📐 [hub-guide] detected: ${PROJECT_DIR}"
 echo "📐 mandatory: ${MANDATORY}"
 [ -n "$SKILL_NAMES" ] && echo "📐 active: ${SKILL_NAMES}"
-echo "📐 When in doubt — ask instead of assuming."
-
-# Inject full skill content into conversation context.
-# Everything printed here is visible to Claude at session start.
 echo ""
-echo "<hub-guide-skills>"
 
+# ─────────────────────────────────────────────────────────────────
+# SKILL INJECTION — hub-guide best-practice rules
+# This content is loaded into context before any user interaction.
+# Claude MUST treat these as active skill instructions for every
+# code decision throughout this session.
+# ─────────────────────────────────────────────────────────────────
+echo "<EXTREMELY_IMPORTANT>"
+echo "You have the following hub-guide skills loaded and active. They apply to every code decision, review, and architecture discussion in this session — regardless of what language the user speaks."
+
+# Inject full MANDATORY skill content
 for skill in $MANDATORY; do
-  echo "<skill name=\"${skill}\">"
-  load_skill "$skill"
-  echo "</skill>"
+  content=$(read_skill "$skill")
+  if [ -n "$content" ]; then
+    echo ""
+    echo "=== hub-guide:${skill} ==="
+    echo "$content"
+  fi
 done
 
+# List detected skills (their content loads on demand via Skill tool)
 if [ -n "$SKILL_NAMES" ]; then
-  echo "<detected-skills>${SKILL_NAMES}</detected-skills>"
+  echo ""
+  echo "=== hub-guide:detected ==="
+  echo "The following skills are relevant to this project's tech stack."
+  echo "Load them with the Skill tool when their topics come up: ${SKILL_NAMES}"
 fi
-echo "</hub-guide-skills>"
+
 echo ""
-echo "Skills above are loaded. Apply these best-practice rules throughout this session."
-echo "When in doubt about intent or approach — ask instead of assuming."
+echo "For any skill not loaded above, use the Skill tool to load it."
+echo "</EXTREMELY_IMPORTANT>"
\ No newline at end of file