Enhance tool documentation and add new features

- Added module-level documentation for memory tools (`remember`, `recall`, `forget`) to clarify their purpose.
- Improved documentation in `recall.rs` and `remember.rs` to describe the functionality and flow of memory entry operations.
- Updated `mod.rs` to include descriptions for the tool trait and execution context.
- Enhanced `plan.rs` with detailed comments on plan-mode signaling tools.
- Documented text search tools in `search.rs` to explain their functionality.
- Improved sequential-thinking tool documentation in `seqthink.rs`.
- Added safety filter documentation in `shell_filter` for credential and git operations.
- Enhanced utility tools documentation, including `cd`, `dir_cache_update`, and `todowrite`.
- Improved rendering documentation in view modules (`chat`, `markdown`, `status`, `workflow`) to clarify rendering flows and purposes.
This commit is contained in:
asepharyana
2026-07-12 11:28:39 +07:00
parent 7158d362fd
commit 2efd40ca88
124 changed files with 2379 additions and 19 deletions
+37
View File
@@ -1,14 +1,41 @@
//! Global registry of running background bash jobs, and control operations
//! (output polling, kill) exposed to the rest of the app.
//!
//! Flow: a process-wide `Mutex<HashMap<String, BashJob>>` (lazily built via
//! `OnceLock`) holds every job spawned via `bgbash::job::spawn_bash_job` →
//! `bash_output` drains new lines for a given job id → `bash_kill` removes
//! a job from the map and signals its child process.
//!
//! Why: a single static map (rather than storing jobs in `AppStateRest`)
//! lets background jobs outlive the borrow of any particular state mutation
//! and be looked up by id from tool calls issued at arbitrary points.
use std::collections::HashMap;
use std::sync::Mutex;
use std::sync::OnceLock;
use super::job::BashJob;
/// Lazily-initialised, process-wide registry of background bash jobs keyed
/// by job id.
///
/// Return: a reference to the static `Mutex<HashMap<...>>`, created on
/// first access.
pub(crate) fn bash_jobs_map() -> &'static Mutex<HashMap<String, BashJob>> {
static JOBS: OnceLock<Mutex<HashMap<String, BashJob>>> = OnceLock::new();
JOBS.get_or_init(|| Mutex::new(HashMap::new()))
}
/// Drain any newly available output lines from a background bash job.
///
/// Flow: look up the job by id → repeatedly call `try_read_line()` until it
/// returns `None` → collect into a Vec.
///
/// Why: non-blocking; a job that hasn't produced new output yields no lines
/// rather than blocking the caller.
///
/// Return: `Some(lines)` if at least one new line was read, `None` if the
/// job doesn't exist, the lock is poisoned, or there was nothing new to read.
pub fn bash_output(id: &str) -> Option<Vec<String>> {
let mut map = bash_jobs_map().lock().ok()?;
let job = map.get_mut(id)?;
@@ -19,6 +46,16 @@ pub fn bash_output(id: &str) -> Option<Vec<String>> {
if lines.is_empty() { None } else { Some(lines) }
}
/// Terminate a running background bash job and remove it from the registry.
///
/// Flow: remove the job from the map → if it has a valid child PID, send
/// `SIGTERM` to it (unix only) → return.
///
/// Why: removing from the map first means a concurrent lookup can no longer
/// see the job even if the signal delivery is delayed.
///
/// Return: `Ok(())` on success, `Err` if the lock is poisoned or no job
/// with that id exists.
pub fn bash_kill(id: &str) -> anyhow::Result<()> {
let mut map = bash_jobs_map().lock().map_err(|e| anyhow::anyhow!("lock error: {}", e))?;
let job = map.remove(id);