Refactor scrolling methods in ScrollState to accept an amount parameter

- Updated `scroll_up` and `scroll_down` methods to take an `amount` parameter for more flexible scrolling.
- Removed the `AgentMode` enum and related methods from the types module to simplify state management.
- Modified `AppStateRest` to remove the `mode` field and adjusted related logic.
- Enhanced `run_subagent` to build tool definitions and handle API key resolution from configuration.
- Updated command parsing to reflect changes in login handling.
- Removed onboarding overlays and related logic from input handling and rendering.
- Improved status bar to reflect connection status and agent readiness.
- Adjusted workflow panel rendering to simplify phase status display.
- Refactored edit log initialization to load from disk if available.
- Updated settings structure to use a HashMap for API keys.
- Enhanced error handling in LlmClient for authentication issues.

src/app/bgbash/control.rs

@@ -22,9 +22,17 @@ pub fn bash_output(id: &str) -> Option<Vec<String>> {
 pub fn bash_kill(id: &str) -> anyhow::Result<()> {
     let mut map = bash_jobs_map().lock().map_err(|e| anyhow::anyhow!("lock error: {}", e))?;
     let job = map.remove(id);
-    if job.is_some() {
-        Ok(())
-    } else {
-        anyhow::bail!("bash job '{}' not found", id)
+    match job {
+        Some(job) => {
+            // Actually terminate the child process via its PID
+            if job.child_pid > 0 {
+                #[cfg(unix)]
+                unsafe {
+                    libc::kill(job.child_pid as i32, libc::SIGTERM);
+                }
+            }
+            Ok(())
+        }
+        None => anyhow::bail!("bash job '{}' not found", id),
     }
 }