feat: refactor agent step limits and enhance workflow orchestration with new findings tool

src/app/subagent/auto.rs

@@ -37,12 +37,6 @@ const SKIP_REVIEW_FILES: &[&str] = &[
     ".gitignore", ".env", ".env.example",
 ];
 
-/// Maximum LLM steps for a quick-review subagent. Keeps reviews fast.
-const QUICK_REVIEW_MAX_STEPS: usize = 2;
-
-/// Maximum LLM steps for background subagents (test gen, arch, security).
-const BG_SUBAGENT_MAX_STEPS: usize = 8;
-
 /// ─── Helpers ───
 ///
 /// Check whether a file path is worth auto-reviewing (not config/lock/data).
@@ -114,8 +108,7 @@ pub fn spawn_quick_review(
         "quick-reviewer".to_string(),
         "reviewer".to_string(),
     )
-    .with_system_prompt(prompt)
-    .with_max_steps(QUICK_REVIEW_MAX_STEPS);
+    .with_system_prompt(prompt);
 
     let mut ctx = build_subagent_context(&def);
     ctx.session_dir = session_dir.to_path_buf();
@@ -189,7 +182,7 @@ pub fn spawn_background_test_gen(
             "coder".to_string(), // needs write access
         )
         .with_system_prompt(prompt)
-        .with_max_steps(BG_SUBAGENT_MAX_STEPS);
+        ;
 
         let mut ctx = build_subagent_context(&def);
         ctx.session_dir = sd;
@@ -269,7 +262,7 @@ pub fn spawn_background_arch_review(
             "reviewer".to_string(),
         )
         .with_system_prompt(prompt)
-        .with_max_steps(BG_SUBAGENT_MAX_STEPS);
+        ;
 
         let mut ctx = build_subagent_context(&def);
         ctx.session_dir = sd;
@@ -355,7 +348,7 @@ pub fn spawn_background_security_review(
             "reviewer".to_string(),
         )
         .with_system_prompt(prompt)
-        .with_max_steps(BG_SUBAGENT_MAX_STEPS);
+        ;
 
         let mut ctx = build_subagent_context(&def);
         ctx.session_dir = sd;

src/app/subagent/context.rs

@@ -45,7 +45,7 @@ pub fn build_subagent_context(def: &AgentDefinition) -> SubagentContext {
             Vec::new()
         }
     });
-    let max_steps = def.max_steps.unwrap_or(25);
+    let max_steps = def.max_steps.unwrap_or(usize::MAX);
     SubagentContext {
         system_prompt: String::new(),
         allowed_tools,

src/app/subagent/division.rs

@@ -43,7 +43,6 @@ pub fn strategy_division() -> AgentDefinition {
         roles::STRATEGY.to_string(),
     )
     .with_system_prompt(crate::resources::DIVISION_PLANNER_PROMPT.to_string())
-    .with_max_steps(15)
     .with_allowed_tools(vec![
         "read".to_string(),
         "grep".to_string(),
@@ -57,6 +56,7 @@ pub fn strategy_division() -> AgentDefinition {
         "lsp_hover".to_string(),
         "lsp_definition".to_string(),
         "lsp_references".to_string(),
+        "read_findings".to_string(),
     ])
 }
 
@@ -70,7 +70,6 @@ pub fn engineering_division() -> AgentDefinition {
         roles::ENGINEERING.to_string(),
     )
     .with_system_prompt(crate::resources::DIVISION_IMPLEMENTER_PROMPT.to_string())
-    .with_max_steps(50)
     .with_allowed_tools(vec![
         "read".to_string(),
         "write".to_string(),
@@ -90,6 +89,7 @@ pub fn engineering_division() -> AgentDefinition {
         "lsp_disconnect".to_string(),
         "todowrite".to_string(),
         "todofinish".to_string(),
+        "read_findings".to_string(),
     ])
 }
 
@@ -103,7 +103,6 @@ pub fn quality_division() -> AgentDefinition {
         roles::QUALITY.to_string(),
     )
     .with_system_prompt(crate::resources::DIVISION_TESTER_PROMPT.to_string())
-    .with_max_steps(30)
     .with_allowed_tools(vec![
         "read".to_string(),
         "write".to_string(),
@@ -119,6 +118,7 @@ pub fn quality_division() -> AgentDefinition {
         "lsp_hover".to_string(),
         "lsp_definition".to_string(),
         "lsp_references".to_string(),
+        "read_findings".to_string(),
     ])
 }
 
@@ -132,7 +132,6 @@ pub fn security_division() -> AgentDefinition {
         roles::SECURITY.to_string(),
     )
     .with_system_prompt(crate::resources::SECURITY_REVIEWER_PROMPT.to_string())
-    .with_max_steps(15)
     .with_allowed_tools(vec![
         "read".to_string(),
         "grep".to_string(),
@@ -146,6 +145,7 @@ pub fn security_division() -> AgentDefinition {
         "lsp_hover".to_string(),
         "lsp_definition".to_string(),
         "lsp_references".to_string(),
+        "read_findings".to_string(),
     ])
 }
 
@@ -159,7 +159,6 @@ pub fn documentation_division() -> AgentDefinition {
         roles::DOCUMENTATION.to_string(),
     )
     .with_system_prompt(crate::resources::DIVISION_DOCUMENTER_PROMPT.to_string())
-    .with_max_steps(15)
     .with_allowed_tools(vec![
         "read".to_string(),
         "write".to_string(),
@@ -168,6 +167,7 @@ pub fn documentation_division() -> AgentDefinition {
         "glob".to_string(),
         "recall".to_string(),
         "remember".to_string(),
+        "read_findings".to_string(),
     ])
 }
 

src/app/subagent/spawn.rs

@@ -30,6 +30,7 @@ impl AgentDefinition {
     }
 
     /// Builder method: limit this agent to at most `steps` LLM calls.
+    #[allow(dead_code)]
     pub fn with_max_steps(mut self, steps: usize) -> Self {
         self.max_steps = Some(steps);
         self