From 6b58977875f809f19cc2d7bb9b2a7dd057d0229e Mon Sep 17 00:00:00 2001
From: asepharyana <superaseph@gmail.com>
Date: Tue, 14 Jul 2026 12:26:32 +0700
Subject: [PATCH] fix: perbaiki 5 warning clippy pre-existing (base untuk TUI
 overhaul)

unnested_or_patterns, collapsible_if, items_after_statements, dan
case_sensitive_file_extension_comparisons di auto.rs, engine.rs, dan
actions/mod.rs.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
---
 src/app/runtime/actions/mod.rs |  8 ++++----
 src/app/subagent/auto.rs       | 10 +++++++---
 src/app/subagent/engine.rs     |  2 +-
 3 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/src/app/runtime/actions/mod.rs b/src/app/runtime/actions/mod.rs
index c6e56b6..163bb1c 100644
--- a/src/app/runtime/actions/mod.rs
+++ b/src/app/runtime/actions/mod.rs
@@ -393,10 +393,10 @@ pub fn apply_action(state: &mut AppStateRest, action: Action) {
                                 state.workflow_engine.agents.clear();
                                 state.workflow_engine.findings.clear();
                             }
-                            if message.to_lowercase().contains("complete") {
-                                if state.misc.overlay == Overlay::Workflow {
-                                    state.misc.overlay = Overlay::None;
-                                }
+                            if message.to_lowercase().contains("complete")
+                                && state.misc.overlay == Overlay::Workflow
+                            {
+                                state.misc.overlay = Overlay::None;
                             }
                             state.push_toast(Toast {
                                 kind: ToastKind::Info,
diff --git a/src/app/subagent/auto.rs b/src/app/subagent/auto.rs
index 1b20717..05dc64d 100644
--- a/src/app/subagent/auto.rs
+++ b/src/app/subagent/auto.rs
@@ -109,17 +109,21 @@ fn is_production_code(path: &str) -> bool {
         matches!(
             c,
             std::path::Component::Normal(seg)
-                if matches!(seg.to_str(), Some("test") | Some("tests") | Some("__tests__"))
+                if matches!(seg.to_str(), Some("test" | "tests" | "__tests__"))
         )
     });
 
     let file_stem = path_obj.file_stem().and_then(|s| s.to_str()).unwrap_or("");
     let is_test_filename = file_stem.starts_with("test_")
         || file_stem.ends_with("_test")
-        || file_stem.ends_with(".test")
+        || std::path::Path::new(file_stem)
+            .extension()
+            .is_some_and(|ext| ext.eq_ignore_ascii_case("test"))
         || file_stem == "spec"
         || file_stem.ends_with("_spec")
-        || file_stem.ends_with(".spec");
+        || std::path::Path::new(file_stem)
+            .extension()
+            .is_some_and(|ext| ext.eq_ignore_ascii_case("spec"));
 
     if in_test_dir || is_test_filename {
         return false;
diff --git a/src/app/subagent/engine.rs b/src/app/subagent/engine.rs
index 3f2d355..2587699 100644
--- a/src/app/subagent/engine.rs
+++ b/src/app/subagent/engine.rs
@@ -8,6 +8,7 @@
 //! are not a weaker link than the main agent.
 
 use std::fmt::Write;
+use sha2::Digest;
 use tokio::sync::mpsc;
 use crate::dto::chat::message::ChatMessage;
 use crate::dto::provider::request::ToolDef;
@@ -456,7 +457,6 @@ pub fn run_subagent(ctx: &SubagentContext, tx: &mpsc::Sender<SubagentEvent>) ->
                                         .unwrap_or("unknown");
                                     let content_sha256 = {
                                         let content = args.get("content").or_else(|| args.get("new"));
-                                        use sha2::Digest;
                                         let hash = sha2::Sha256::digest(
                                             content.and_then(|v| v.as_str()).unwrap_or("").as_bytes(),
                                         );