Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
62fa85867c | ||
|
|
f75ff740ac | ||
|
|
e349a35716 | ||
|
|
f1f58b9996 | ||
|
|
f4c02fd64e | ||
|
|
e982cbeb04 | ||
|
|
20ce81a6be | ||
|
|
21e3ccc891 | ||
|
|
992e60980c | ||
|
|
74b1ad4302 |
@@ -1,3 +1,38 @@
|
|||||||
|
# [1.21.0](https://github.com/asepharyana/zesdex/compare/v1.20.2...v1.21.0) (2026-08-28)
|
||||||
|
|
||||||
|
|
||||||
|
### Features
|
||||||
|
|
||||||
|
* **agent:** hive-mind consensus synthesis pakai LLM nyata ([f75ff74](https://github.com/asepharyana/zesdex/commit/f75ff740ac2fa63340656e1e8215440f5e48063d))
|
||||||
|
|
||||||
|
## [1.20.2](https://github.com/asepharyana/zesdex/compare/v1.20.1...v1.20.2) (2026-08-28)
|
||||||
|
|
||||||
|
|
||||||
|
### Bug Fixes
|
||||||
|
|
||||||
|
* **agent:** recall search + memory_dir fallback + bersihkan dead llm_client ([f1f58b9](https://github.com/asepharyana/zesdex/commit/f1f58b9996f8eb58871d44fdd41c2d863874f253))
|
||||||
|
|
||||||
|
## [1.20.1](https://github.com/asepharyana/zesdex/compare/v1.20.0...v1.20.1) (2026-08-28)
|
||||||
|
|
||||||
|
|
||||||
|
### Bug Fixes
|
||||||
|
|
||||||
|
* **agent:** subagent patuhi tool-calling contract + truncation char-safe ([e982cbe](https://github.com/asepharyana/zesdex/commit/e982cbeb041baea9cd500e2a29862a7eca9e6e17))
|
||||||
|
|
||||||
|
# [1.20.0](https://github.com/asepharyana/zesdex/compare/v1.19.6...v1.20.0) (2026-08-28)
|
||||||
|
|
||||||
|
|
||||||
|
### Features
|
||||||
|
|
||||||
|
* **agent:** subagent tool paralel + auto-load AGENTS.md + verify cek setelah edit ([21e3ccc](https://github.com/asepharyana/zesdex/commit/21e3ccc891ab886044a5f0a770db710769d1287b))
|
||||||
|
|
||||||
|
## [1.19.6](https://github.com/asepharyana/zesdex/compare/v1.19.5...v1.19.6) (2026-08-27)
|
||||||
|
|
||||||
|
|
||||||
|
### Performance Improvements
|
||||||
|
|
||||||
|
* **agent:** eksekusi tool read-only paralel seperti Claude Code ([74b1ad4](https://github.com/asepharyana/zesdex/commit/74b1ad43020a11ca27e60e3a24de0db5d1ab37b4))
|
||||||
|
|
||||||
## [1.19.5](https://github.com/asepharyana/zesdex/compare/v1.19.4...v1.19.5) (2026-08-27)
|
## [1.19.5](https://github.com/asepharyana/zesdex/compare/v1.19.4...v1.19.5) (2026-08-27)
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
Generated
+12
-11
@@ -4862,7 +4862,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "zesdex-api"
|
name = "zesdex-api"
|
||||||
version = "1.19.4"
|
version = "1.20.1"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"argon2",
|
"argon2",
|
||||||
@@ -4885,11 +4885,12 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "zesdex-application"
|
name = "zesdex-application"
|
||||||
version = "1.19.4"
|
version = "1.20.1"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"base64",
|
"base64",
|
||||||
"chrono",
|
"chrono",
|
||||||
|
"futures-util",
|
||||||
"serde",
|
"serde",
|
||||||
"serde_json",
|
"serde_json",
|
||||||
"sha2 0.11.0",
|
"sha2 0.11.0",
|
||||||
@@ -4902,7 +4903,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "zesdex-bootstrap"
|
name = "zesdex-bootstrap"
|
||||||
version = "1.19.4"
|
version = "1.20.1"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"chrono",
|
"chrono",
|
||||||
@@ -4919,7 +4920,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "zesdex-daemon"
|
name = "zesdex-daemon"
|
||||||
version = "1.19.4"
|
version = "1.20.1"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"base64",
|
"base64",
|
||||||
@@ -4943,7 +4944,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "zesdex-domain"
|
name = "zesdex-domain"
|
||||||
version = "1.19.4"
|
version = "1.20.1"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"base64",
|
"base64",
|
||||||
@@ -4959,7 +4960,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "zesdex-gateway"
|
name = "zesdex-gateway"
|
||||||
version = "1.19.4"
|
version = "1.20.1"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"axum",
|
"axum",
|
||||||
@@ -4986,7 +4987,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "zesdex-grpc"
|
name = "zesdex-grpc"
|
||||||
version = "1.19.4"
|
version = "1.20.1"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"axum",
|
"axum",
|
||||||
@@ -5003,7 +5004,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "zesdex-infrastructure"
|
name = "zesdex-infrastructure"
|
||||||
version = "1.19.4"
|
version = "1.20.1"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"argon2",
|
"argon2",
|
||||||
@@ -5051,7 +5052,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "zesdex-tui"
|
name = "zesdex-tui"
|
||||||
version = "1.19.4"
|
version = "1.20.1"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"base64",
|
"base64",
|
||||||
@@ -5077,7 +5078,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "zesdex-web"
|
name = "zesdex-web"
|
||||||
version = "1.19.4"
|
version = "1.20.1"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"axum",
|
"axum",
|
||||||
@@ -5097,7 +5098,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "zesdex-ws"
|
name = "zesdex-ws"
|
||||||
version = "1.19.4"
|
version = "1.20.1"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"axum",
|
"axum",
|
||||||
|
|||||||
+1
-1
@@ -15,7 +15,7 @@ members = [
|
|||||||
]
|
]
|
||||||
|
|
||||||
[workspace.package]
|
[workspace.package]
|
||||||
version = "1.19.5"
|
version = "1.21.0"
|
||||||
edition = "2021"
|
edition = "2021"
|
||||||
authors = ["asepharyana <superaseph@gmail.com>"]
|
authors = ["asepharyana <superaseph@gmail.com>"]
|
||||||
|
|
||||||
|
|||||||
@@ -16,6 +16,7 @@ uuid.workspace = true
|
|||||||
anyhow.workspace = true
|
anyhow.workspace = true
|
||||||
tracing.workspace = true
|
tracing.workspace = true
|
||||||
tokio.workspace = true
|
tokio.workspace = true
|
||||||
|
futures-util.workspace = true
|
||||||
base64.workspace = true
|
base64.workspace = true
|
||||||
sha2.workspace = true
|
sha2.workspace = true
|
||||||
url.workspace = true
|
url.workspace = true
|
||||||
|
|||||||
@@ -11,6 +11,17 @@ pub trait ToolExecutor: Send + Sync {
|
|||||||
tool_name: &str,
|
tool_name: &str,
|
||||||
args: &serde_json::Value,
|
args: &serde_json::Value,
|
||||||
) -> impl Future<Output = Result<String>> + Send;
|
) -> impl Future<Output = Result<String>> + Send;
|
||||||
|
|
||||||
|
/// Whether a tool is *read-only* and therefore safe to run concurrently
|
||||||
|
/// with other read-only tools in the same assistant message.
|
||||||
|
///
|
||||||
|
/// Defaults to `false` (sequential) so a caller that does not know the
|
||||||
|
/// tool surface stays conservative. Concrete executors that know their
|
||||||
|
/// tools override this — e.g. return `true` for `read`/`grep`/`glob`.
|
||||||
|
fn is_parallel_safe(&self, tool_name: &str) -> bool {
|
||||||
|
let _ = tool_name;
|
||||||
|
false
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Service for running agent turns asynchronously.
|
/// Service for running agent turns asynchronously.
|
||||||
|
|||||||
@@ -5,7 +5,7 @@ use tracing::{debug, info, warn};
|
|||||||
|
|
||||||
use zesdex_domain::agent::{AgentTurnParams, TurnEvent};
|
use zesdex_domain::agent::{AgentTurnParams, TurnEvent};
|
||||||
use zesdex_domain::core::{ChatMessage, StreamEvent, ToolDef};
|
use zesdex_domain::core::{ChatMessage, StreamEvent, ToolDef};
|
||||||
use zesdex_domain::main_agent_prompt;
|
use zesdex_domain::main_agent_prompt_with_project_context;
|
||||||
|
|
||||||
use super::ToolExecutor;
|
use super::ToolExecutor;
|
||||||
use crate::ports::ProviderService;
|
use crate::ports::ProviderService;
|
||||||
@@ -111,6 +111,46 @@ fn conversation_chars(messages: &[ChatMessage]) -> usize {
|
|||||||
.sum()
|
.sum()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// The maximum combined size (characters) of project-rule files injected into
|
||||||
|
/// the system prompt, so a huge AGENTS.md cannot blow the context window.
|
||||||
|
const PROJECT_CONTEXT_MAX_CHARS: usize = 12_000;
|
||||||
|
|
||||||
|
/// Case-insensitive rule filenames auto-loaded from the workspace root into
|
||||||
|
/// the system prompt, matching the Claude-Code/AGENTS.md convention.
|
||||||
|
const RULE_FILENAMES: [&str; 6] = [
|
||||||
|
"AGENTS.md",
|
||||||
|
"agent.md",
|
||||||
|
"CLAUDE.md",
|
||||||
|
"claude.md",
|
||||||
|
".cursorrules",
|
||||||
|
".zesdexrules",
|
||||||
|
];
|
||||||
|
|
||||||
|
/// Build a compact "project context" block from the repo's convention files
|
||||||
|
/// (AGENTS.md, CLAUDE.md, .cursorrules, …) found at the workspace root.
|
||||||
|
///
|
||||||
|
/// Follows the Claude-Code convention of loading AGENTS.md at startup so the
|
||||||
|
/// model starts each turn with the repo's rules. Reads are best-effort and
|
||||||
|
/// capped at [`PROJECT_CONTEXT_MAX_CHARS`] total; missing files are skipped.
|
||||||
|
fn build_project_context(root: &std::path::Path) -> String {
|
||||||
|
let mut ctx = String::new();
|
||||||
|
for file in RULE_FILENAMES {
|
||||||
|
let full = root.join(file);
|
||||||
|
if let Ok(content) = std::fs::read_to_string(&full) {
|
||||||
|
ctx.push_str(&format!("\n### {file}\n```\n{}\n```", content.trim()));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
let context = ctx.trim().to_string();
|
||||||
|
if context.len() <= PROJECT_CONTEXT_MAX_CHARS {
|
||||||
|
return context;
|
||||||
|
}
|
||||||
|
context
|
||||||
|
.chars()
|
||||||
|
.take(PROJECT_CONTEXT_MAX_CHARS)
|
||||||
|
.collect::<String>()
|
||||||
|
+ "\n...[project context truncated]"
|
||||||
|
}
|
||||||
|
|
||||||
/// Track repeated tool-call errors so the loop can recover instead of
|
/// Track repeated tool-call errors so the loop can recover instead of
|
||||||
/// burning iterations retrying the same failing tool.
|
/// burning iterations retrying the same failing tool.
|
||||||
#[derive(Default)]
|
#[derive(Default)]
|
||||||
@@ -187,6 +227,53 @@ async fn execute_tool_call<T: ToolExecutor>(
|
|||||||
output
|
output
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ---------------------------------------------------------------------------
|
||||||
|
// Helper: bounded-parallel execution of read-only tool calls.
|
||||||
|
// ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
/// Maximum number of read-only tool calls executed concurrently in a single
|
||||||
|
/// assistant batch. Models rarely emit more than a handful of reads per
|
||||||
|
/// message; this cap keeps resource usage bounded while still removing the
|
||||||
|
/// serial round-trip latency of many independent lookups.
|
||||||
|
const MAX_PARALLEL_TOOLS: usize = 8;
|
||||||
|
|
||||||
|
fn tool_executor_ref<T: ToolExecutor>(tool_executor: &T) -> &T {
|
||||||
|
tool_executor
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Execute a batch of *read-only* tool calls concurrently (bounded by
|
||||||
|
/// [`MAX_PARALLEL_TOOLS`]) and return their outputs **in the original call
|
||||||
|
/// order**.
|
||||||
|
///
|
||||||
|
/// Order preservation matters: OpenAI/Anthropic tool-calling contracts expect
|
||||||
|
/// tool-result messages to appear in the same order as the `tool_calls`
|
||||||
|
/// emitted in the assistant message. Without it, the model sees shuffled
|
||||||
|
/// results and loses track of which result belongs to which call.
|
||||||
|
///
|
||||||
|
/// Each call still pushes its `TurnEvent::ToolResult` (so the TUI shows each
|
||||||
|
/// tool as it completes) but the returned `Vec` is ordered by the input index.
|
||||||
|
async fn execute_tool_calls_in_parallel<T: ToolExecutor>(
|
||||||
|
tool_executor: &T,
|
||||||
|
turn_events: &Arc<Mutex<VecDeque<TurnEvent>>>,
|
||||||
|
tool_calls: &[zesdex_domain::core::ToolCall],
|
||||||
|
) -> Vec<String> {
|
||||||
|
let semaphore = Arc::new(tokio::sync::Semaphore::new(MAX_PARALLEL_TOOLS));
|
||||||
|
let executor_ref = tool_executor_ref(tool_executor);
|
||||||
|
|
||||||
|
let futures = tool_calls.iter().map(|tc| {
|
||||||
|
let tc = tc.clone();
|
||||||
|
let events = turn_events.clone();
|
||||||
|
let sem = semaphore.clone();
|
||||||
|
async move {
|
||||||
|
// Acquire a permit to bound concurrency across the batch.
|
||||||
|
let _permit = sem.acquire_owned().await;
|
||||||
|
execute_tool_call(executor_ref, &events, &tc).await
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
futures_util::future::join_all(futures).await
|
||||||
|
}
|
||||||
|
|
||||||
// ---------------------------------------------------------------------------
|
// ---------------------------------------------------------------------------
|
||||||
// Helper: emit usage event from optional LLM response metadata.
|
// Helper: emit usage event from optional LLM response metadata.
|
||||||
// ---------------------------------------------------------------------------
|
// ---------------------------------------------------------------------------
|
||||||
@@ -294,9 +381,17 @@ impl<P: ProviderService, T: ToolExecutor> super::AgentTurnService for AgentTurnS
|
|||||||
|
|
||||||
// Insert system prompt at position 0 once and keep it there for the
|
// Insert system prompt at position 0 once and keep it there for the
|
||||||
// entire turn, avoiding per-iteration clones of the full message list.
|
// entire turn, avoiding per-iteration clones of the full message list.
|
||||||
|
// Auto-load repo conventions (AGENTS.md / CLAUDE.md / .cursorrules)
|
||||||
|
// from the first workspace root, like Claude Code does at startup.
|
||||||
|
let project_context = params
|
||||||
|
.workspace_roots
|
||||||
|
.first()
|
||||||
|
.map(|root| build_project_context(root))
|
||||||
|
.unwrap_or_default();
|
||||||
|
let system_prompt = main_agent_prompt_with_project_context(&project_context);
|
||||||
params
|
params
|
||||||
.messages
|
.messages
|
||||||
.insert(0, ChatMessage::system(main_agent_prompt()));
|
.insert(0, ChatMessage::system(system_prompt));
|
||||||
let original_count = params.messages.len();
|
let original_count = params.messages.len();
|
||||||
|
|
||||||
// Estimate request complexity from the last user message.
|
// Estimate request complexity from the last user message.
|
||||||
@@ -384,10 +479,42 @@ impl<P: ProviderService, T: ToolExecutor> super::AgentTurnService for AgentTurnS
|
|||||||
params.messages.push(assistant_msg);
|
params.messages.push(assistant_msg);
|
||||||
|
|
||||||
// ── Execute each tool call ──────────────────────────
|
// ── Execute each tool call ──────────────────────────
|
||||||
|
//
|
||||||
|
// If the whole batch is made of *read-only* tools
|
||||||
|
// (read/grep/glob/…), run it concurrently with bounded
|
||||||
|
// parallelism — a big latency win for coding turns that
|
||||||
|
// emit several independent lookups in one message. Any
|
||||||
|
// single mutating tool forces the whole batch back to the
|
||||||
|
// safe sequential path so writes never race.
|
||||||
|
//
|
||||||
|
// Results are always collected in the original call order
|
||||||
|
// to honour the tool-calling contract.
|
||||||
|
let parallel = tool_calls.len() > 1
|
||||||
|
&& tool_calls
|
||||||
|
.iter()
|
||||||
|
.all(|tc| self.tool_executor.is_parallel_safe(&tc.function.name));
|
||||||
|
let outputs: Vec<String> = if parallel {
|
||||||
|
execute_tool_calls_in_parallel(
|
||||||
|
self.tool_executor.as_ref(),
|
||||||
|
¶ms.turn_events,
|
||||||
|
&tool_calls,
|
||||||
|
)
|
||||||
|
.await
|
||||||
|
} else {
|
||||||
|
let mut sequential = Vec::with_capacity(tool_calls.len());
|
||||||
for tc in &tool_calls {
|
for tc in &tool_calls {
|
||||||
let output =
|
let out = execute_tool_call(
|
||||||
execute_tool_call(self.tool_executor.as_ref(), ¶ms.turn_events, tc)
|
self.tool_executor.as_ref(),
|
||||||
|
¶ms.turn_events,
|
||||||
|
tc,
|
||||||
|
)
|
||||||
.await;
|
.await;
|
||||||
|
sequential.push(out);
|
||||||
|
}
|
||||||
|
sequential
|
||||||
|
};
|
||||||
|
|
||||||
|
for (tc, output) in tool_calls.iter().zip(outputs) {
|
||||||
if output.starts_with("Error:") {
|
if output.starts_with("Error:") {
|
||||||
errors.record(&tc.function.name, &output, &mut params.messages);
|
errors.record(&tc.function.name, &output, &mut params.messages);
|
||||||
}
|
}
|
||||||
@@ -479,7 +606,6 @@ pub async fn compact_messages_with_ai<P: ProviderService>(
|
|||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use super::*;
|
use super::*;
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn truncate_short_output_is_unchanged() {
|
fn truncate_short_output_is_unchanged() {
|
||||||
let out = "short".to_string();
|
let out = "short".to_string();
|
||||||
@@ -536,4 +662,83 @@ mod tests {
|
|||||||
];
|
];
|
||||||
assert_eq!(conversation_chars(&messages), 3 + 11 + 6);
|
assert_eq!(conversation_chars(&messages), 3 + 11 + 6);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// A fake executor that reports parallel-safety for read-only tools and
|
||||||
|
/// whose `execute` sleeps on the first call to prove the batch runs
|
||||||
|
/// concurrently (a sequential loop would pay the sleep per call).
|
||||||
|
struct FakeExecutor;
|
||||||
|
|
||||||
|
impl ToolExecutor for FakeExecutor {
|
||||||
|
async fn execute(&self, name: &str, _args: &serde_json::Value) -> anyhow::Result<String> {
|
||||||
|
if name == "read" {
|
||||||
|
// 30ms sleep on every read; a parallel batch of 3 would
|
||||||
|
// finish in ~30ms instead of ~90ms sequentially.
|
||||||
|
tokio::time::sleep(std::time::Duration::from_millis(30)).await;
|
||||||
|
}
|
||||||
|
Ok(format!("out:{name}"))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn is_parallel_safe(&self, name: &str) -> bool {
|
||||||
|
matches!(name, "read" | "grep")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn tc(name: &str, id: usize) -> zesdex_domain::core::ToolCall {
|
||||||
|
zesdex_domain::core::ToolCall {
|
||||||
|
id: format!("call_{id}"),
|
||||||
|
type_: "function".to_string(),
|
||||||
|
function: zesdex_domain::core::ToolFunction {
|
||||||
|
name: name.to_string(),
|
||||||
|
arguments: serde_json::Value::String(String::new()),
|
||||||
|
},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn parallel_batch_runs_concurrently_and_preserves_order() {
|
||||||
|
let executor = FakeExecutor;
|
||||||
|
let events = Arc::new(Mutex::new(VecDeque::new()));
|
||||||
|
let calls = vec![tc("read", 1), tc("grep", 2), tc("read", 3)];
|
||||||
|
|
||||||
|
// All three are parallel-safe.
|
||||||
|
assert!(calls
|
||||||
|
.iter()
|
||||||
|
.all(|c| executor.is_parallel_safe(&c.function.name)));
|
||||||
|
|
||||||
|
let rt = tokio::runtime::Builder::new_multi_thread()
|
||||||
|
.enable_time()
|
||||||
|
.build()
|
||||||
|
.unwrap();
|
||||||
|
let started = std::time::Instant::now();
|
||||||
|
let outputs = rt.block_on(execute_tool_calls_in_parallel(&executor, &events, &calls));
|
||||||
|
let elapsed = started.elapsed();
|
||||||
|
|
||||||
|
// Results are in *original* call order (read, grep, read).
|
||||||
|
assert_eq!(
|
||||||
|
outputs,
|
||||||
|
vec![
|
||||||
|
"out:read".to_string(),
|
||||||
|
"out:grep".to_string(),
|
||||||
|
"out:read".to_string()
|
||||||
|
]
|
||||||
|
);
|
||||||
|
// Two reads sleep 30ms each; sequential would take ~60ms+ for the
|
||||||
|
// two reads, parallel keeps the whole batch under 60ms.
|
||||||
|
assert!(
|
||||||
|
elapsed < std::time::Duration::from_millis(60),
|
||||||
|
"batch took {elapsed:?}, expected parallel execution"
|
||||||
|
);
|
||||||
|
assert!(elapsed >= std::time::Duration::from_millis(25));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn mutating_batch_falls_back_to_sequential_path() {
|
||||||
|
// A batch containing a mutating tool is not eligible for the parallel
|
||||||
|
// path, so the main loop keeps results ordered and side-effects safe.
|
||||||
|
let executor = FakeExecutor;
|
||||||
|
let calls = [tc("read", 1), tc("edit", 2)];
|
||||||
|
assert!(!calls
|
||||||
|
.iter()
|
||||||
|
.all(|c| executor.is_parallel_safe(&c.function.name)));
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -41,10 +41,43 @@ architectural plans and `todowrite` to maintain granular task checklists.
|
|||||||
4. TOOL EXECUTION: Execute individual tools (file edits, terminal commands) \
|
4. TOOL EXECUTION: Execute individual tools (file edits, terminal commands) \
|
||||||
within or guided by your workflows. If an error occurs, analyse and fix it.
|
within or guided by your workflows. If an error occurs, analyse and fix it.
|
||||||
|
|
||||||
|
VERIFY AFTER EDIT (CLAUDE-CODE STYLE):
|
||||||
|
- After modifying code (edit/write), run the repo's check command via `bash` \
|
||||||
|
before ending the turn: `cargo check` / `cargo clippy` / `cargo test` for Rust, \
|
||||||
|
or the equivalent lint/test (`bun run lint && bun run test`, `npm test`, etc.) \
|
||||||
|
for other stacks. Pick the project's actual verify command (see PROJECT \
|
||||||
|
CONTEXT / AGENTS.md when present).
|
||||||
|
- If the check fails, fix the errors you can see and re-run; only end the turn \
|
||||||
|
after the check passes or you cannot resolve a failure yourself (then report it \
|
||||||
|
explicitly).
|
||||||
|
- Do NOT claim code compiles or works without running a real check.
|
||||||
|
|
||||||
Respond conversationally, concisely, and helpfully."
|
Respond conversationally, concisely, and helpfully."
|
||||||
.to_string()
|
.to_string()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Build the main-agent system prompt including an injected block of project
|
||||||
|
/// context (AGENTS.md / CLAUDE.md / project rules).
|
||||||
|
///
|
||||||
|
/// Like Claude Code, which loads AGENTS.md at startup so the model starts with
|
||||||
|
/// the repo's conventions, this wraps [`main_agent_prompt`] and appends a
|
||||||
|
/// clearly-delimited `## PROJECT CONTEXT` section carrying the rules the user
|
||||||
|
/// keeps next to their code. When `project_context` is empty the returned
|
||||||
|
/// prompt is identical to [`main_agent_prompt`], so callers can fall back
|
||||||
|
/// safely.
|
||||||
|
pub fn main_agent_prompt_with_project_context(project_context: &str) -> String {
|
||||||
|
let base = main_agent_prompt();
|
||||||
|
let context = project_context.trim();
|
||||||
|
if context.is_empty() {
|
||||||
|
return base;
|
||||||
|
}
|
||||||
|
format!(
|
||||||
|
"{base}\n\n\
|
||||||
|
## PROJECT CONTEXT (repo rules — follow these conventions)\n\
|
||||||
|
{context}"
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
/// Build a subagent directive prompt.
|
/// Build a subagent directive prompt.
|
||||||
///
|
///
|
||||||
/// The directive is embedded in a system message that also communicates the
|
/// The directive is embedded in a system message that also communicates the
|
||||||
@@ -119,6 +152,25 @@ mod tests {
|
|||||||
assert!(prompt.contains("WORKFLOW FIRST"));
|
assert!(prompt.contains("WORKFLOW FIRST"));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn project_context_prompt_appends_context_and_keeps_base() {
|
||||||
|
let base = main_agent_prompt();
|
||||||
|
let with_ctx = main_agent_prompt_with_project_context("## AGENTS.md\nUse cargo clippy.");
|
||||||
|
assert!(with_ctx.contains("Zesdex"), "base prompt must be preserved");
|
||||||
|
assert!(with_ctx.contains("PROJECT CONTEXT"));
|
||||||
|
assert!(with_ctx.contains("Use cargo clippy."));
|
||||||
|
assert!(with_ctx.contains(&base));
|
||||||
|
// The base section should appear before the context section.
|
||||||
|
assert!(with_ctx.find("PROJECT CONTEXT").unwrap() > with_ctx.find("Zesdex").unwrap());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn empty_project_context_returns_base_prompt() {
|
||||||
|
let base = main_agent_prompt();
|
||||||
|
assert_eq!(main_agent_prompt_with_project_context(""), base);
|
||||||
|
assert_eq!(main_agent_prompt_with_project_context(" "), base);
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn subagent_directive_includes_directive_text() {
|
fn subagent_directive_includes_directive_text() {
|
||||||
let prompt = subagent_directive("test directive", "/home", "/home/project");
|
let prompt = subagent_directive("test directive", "/home", "/home/project");
|
||||||
|
|||||||
@@ -58,6 +58,9 @@ pub use agent::*;
|
|||||||
// Sub-module items need explicit re-exports
|
// Sub-module items need explicit re-exports
|
||||||
pub use agent::defaults::*;
|
pub use agent::defaults::*;
|
||||||
pub use agent::progress::AgentProgress;
|
pub use agent::progress::AgentProgress;
|
||||||
pub use agent::prompt::{compaction_prompt, main_agent_prompt, subagent_directive};
|
pub use agent::prompt::{
|
||||||
|
compaction_prompt, main_agent_prompt, main_agent_prompt_with_project_context,
|
||||||
|
subagent_directive,
|
||||||
|
};
|
||||||
pub use subagent::*;
|
pub use subagent::*;
|
||||||
pub use workflow::*;
|
pub use workflow::*;
|
||||||
|
|||||||
@@ -130,7 +130,7 @@ pub fn spawn_background_review(
|
|||||||
);
|
);
|
||||||
format!(
|
format!(
|
||||||
"{}...\n[diff truncated at {} characters]",
|
"{}...\n[diff truncated at {} characters]",
|
||||||
&diff[..MAX_DIFF_CHARS],
|
crate::utils::truncate_chars(&diff, MAX_DIFF_CHARS),
|
||||||
MAX_DIFF_CHARS
|
MAX_DIFF_CHARS
|
||||||
)
|
)
|
||||||
} else {
|
} else {
|
||||||
|
|||||||
@@ -14,7 +14,8 @@ use tracing::{debug, info, instrument};
|
|||||||
use crate::llm::provider::LlmClient;
|
use crate::llm::provider::LlmClient;
|
||||||
use crate::subagent::context::SubagentContext;
|
use crate::subagent::context::SubagentContext;
|
||||||
use crate::subagent::division::{tools_for, AccessTier};
|
use crate::subagent::division::{tools_for, AccessTier};
|
||||||
use crate::tools::{tool_defs, ToolCtx};
|
use crate::tools::{tool_defs, Tool, ToolCtx};
|
||||||
|
use serde_json::Value;
|
||||||
use zesdex_domain::agent::progress::AgentProgress;
|
use zesdex_domain::agent::progress::AgentProgress;
|
||||||
use zesdex_domain::core::tool_call::sanitize_tool_arguments;
|
use zesdex_domain::core::tool_call::sanitize_tool_arguments;
|
||||||
use zesdex_domain::core::ChatMessage;
|
use zesdex_domain::core::ChatMessage;
|
||||||
@@ -31,6 +32,95 @@ const TOOL_OUTPUT_MAX_CHARS: usize = 12_000;
|
|||||||
/// recovery note steering the model to a different approach.
|
/// recovery note steering the model to a different approach.
|
||||||
const MAX_CONSECUTIVE_TOOL_ERRORS: usize = 3;
|
const MAX_CONSECUTIVE_TOOL_ERRORS: usize = 3;
|
||||||
|
|
||||||
|
/// Maximum number of read-only tool calls executed concurrently in a single
|
||||||
|
/// subagent batch. Read-only tools (read/grep/glob/…) block on disk I/O, so
|
||||||
|
/// running them on parallel OS threads removes the serial round-trip latency
|
||||||
|
/// for a batch of independent lookups, mirroring the main turn loop.
|
||||||
|
const MAX_PARALLEL_TOOLS: usize = 8;
|
||||||
|
|
||||||
|
/// Execute a batch of tool calls, running read-only tools concurrently when
|
||||||
|
/// the whole batch is parallel-safe.
|
||||||
|
///
|
||||||
|
/// Returns one `(tool_call_id, tool_name, result)` per call **in the original
|
||||||
|
/// call order** (OpenAI/Anthropic tool-result ordering contract). `Tool::run`
|
||||||
|
/// is synchronous, so real parallelism comes from scoped OS threads; `Tool`
|
||||||
|
/// and `ToolCtx` are `Send + Sync`, so the borrowed references can be shared
|
||||||
|
/// across the short-lived scoped threads.
|
||||||
|
///
|
||||||
|
/// If any single tool in the batch mutates state (edit/write/bash/git/…), the
|
||||||
|
/// whole batch falls back to the safe sequential path so writes never race.
|
||||||
|
fn execute_tool_batch(
|
||||||
|
tools: &[Box<dyn Tool>],
|
||||||
|
tool_ctx: &ToolCtx,
|
||||||
|
tool_calls: &[zesdex_domain::core::ToolCall],
|
||||||
|
) -> Vec<(String, String, String)> {
|
||||||
|
let parallel = tool_calls.len() > 1
|
||||||
|
&& tool_calls
|
||||||
|
.iter()
|
||||||
|
.all(|tc| crate::tools::tool_is_parallel_safe(&tc.function.name));
|
||||||
|
|
||||||
|
if !parallel {
|
||||||
|
// Sequential fallback (kept identical to the historical behavior).
|
||||||
|
return tool_calls
|
||||||
|
.iter()
|
||||||
|
.map(|tc| {
|
||||||
|
let tool_name = tc.function.name.clone();
|
||||||
|
let args = sanitize_tool_arguments(&tc.function.arguments);
|
||||||
|
let result = run_one_tool(tools, tool_ctx, &tool_name, &args);
|
||||||
|
(tc.id.clone(), tool_name, result)
|
||||||
|
})
|
||||||
|
.collect();
|
||||||
|
}
|
||||||
|
|
||||||
|
// Bounded parallel path: process the batch in windows of
|
||||||
|
// `MAX_PARALLEL_TOOLS` so concurrency stays bounded, joining each window
|
||||||
|
// before the next so results stay in original order.
|
||||||
|
let mut ordered = Vec::with_capacity(tool_calls.len());
|
||||||
|
for window in tool_calls.chunks(MAX_PARALLEL_TOOLS) {
|
||||||
|
let window_results = std::thread::scope(|s| {
|
||||||
|
let handles: Vec<_> = window
|
||||||
|
.iter()
|
||||||
|
.map(|tc| {
|
||||||
|
let tool_name = tc.function.name.clone();
|
||||||
|
let args = sanitize_tool_arguments(&tc.function.arguments);
|
||||||
|
s.spawn(move || {
|
||||||
|
debug!("Subagent executing tool: {tool_name}");
|
||||||
|
run_one_tool(tools, tool_ctx, &tool_name, &args)
|
||||||
|
})
|
||||||
|
})
|
||||||
|
.collect();
|
||||||
|
handles
|
||||||
|
.into_iter()
|
||||||
|
.map(|h| {
|
||||||
|
h.join()
|
||||||
|
.unwrap_or_else(|_| "Error: tool panicked".to_string())
|
||||||
|
})
|
||||||
|
.collect::<Vec<_>>()
|
||||||
|
});
|
||||||
|
for (tc, result) in window.iter().zip(window_results) {
|
||||||
|
ordered.push((tc.id.clone(), tc.function.name.clone(), result));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
ordered
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Run a single synchronous tool call and capture its result string.
|
||||||
|
fn run_one_tool(
|
||||||
|
tools: &[Box<dyn Tool>],
|
||||||
|
tool_ctx: &ToolCtx,
|
||||||
|
tool_name: &str,
|
||||||
|
args: &Value,
|
||||||
|
) -> String {
|
||||||
|
if let Some(tool) = tools.iter().find(|t| t.name() == tool_name) {
|
||||||
|
match tool.run(tool_ctx, args) {
|
||||||
|
Ok(output) => output,
|
||||||
|
Err(e) => format!("Error: {e}"),
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
format!("Unknown tool: {tool_name}")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/// Pick a `max_tokens` budget proportional to the directive's length.
|
/// Pick a `max_tokens` budget proportional to the directive's length.
|
||||||
fn adaptive_max_tokens(directive_len: usize) -> u32 {
|
fn adaptive_max_tokens(directive_len: usize) -> u32 {
|
||||||
if directive_len <= 80 {
|
if directive_len <= 80 {
|
||||||
@@ -130,7 +220,7 @@ pub async fn run_agent(
|
|||||||
.await?;
|
.await?;
|
||||||
|
|
||||||
let content = response_msg.content.clone().unwrap_or_default();
|
let content = response_msg.content.clone().unwrap_or_default();
|
||||||
let tool_calls = response_msg.tool_calls.unwrap_or_default();
|
let tool_calls = response_msg.tool_calls.clone().unwrap_or_default();
|
||||||
|
|
||||||
// If no tool calls, we're done — return content
|
// If no tool calls, we're done — return content
|
||||||
if tool_calls.is_empty() {
|
if tool_calls.is_empty() {
|
||||||
@@ -139,12 +229,18 @@ pub async fn run_agent(
|
|||||||
return Ok(content);
|
return Ok(content);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Execute tool calls
|
// Push the assistant message (with its tool_calls) BEFORE executing
|
||||||
for tc in &tool_calls {
|
// so the tool-calling contract is honoured: tool results reference
|
||||||
let tool_name = &tc.function.name;
|
// the calls declared in the preceding assistant message. Without
|
||||||
let args = sanitize_tool_arguments(&tc.function.arguments);
|
// this, the history is malformed (`[...tool, tool, assistant]`).
|
||||||
|
messages.push(response_msg);
|
||||||
|
|
||||||
debug!("Subagent executing tool: {tool_name}");
|
// Execute tool calls — read-only batches run concurrently (bounded,
|
||||||
|
// order preserved); any mutating tool forces the safe sequential path.
|
||||||
|
let results = execute_tool_batch(&tools, &tool_ctx, &tool_calls);
|
||||||
|
|
||||||
|
for (id, tool_name, result) in results {
|
||||||
|
debug!("Subagent tool {tool_name} finished");
|
||||||
|
|
||||||
report_progress(
|
report_progress(
|
||||||
&tool_ctx,
|
&tool_ctx,
|
||||||
@@ -155,15 +251,6 @@ pub async fn run_agent(
|
|||||||
),
|
),
|
||||||
);
|
);
|
||||||
|
|
||||||
let result = if let Some(tool) = tools.iter().find(|t| t.name() == tool_name) {
|
|
||||||
match tool.run(&tool_ctx, &args) {
|
|
||||||
Ok(output) => output,
|
|
||||||
Err(e) => format!("Error: {e}"),
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
format!("Unknown tool: {tool_name}")
|
|
||||||
};
|
|
||||||
|
|
||||||
// Error-recovery: if the same tool keeps failing, inject a
|
// Error-recovery: if the same tool keeps failing, inject a
|
||||||
// system note steering the model to a different approach.
|
// system note steering the model to a different approach.
|
||||||
if result.starts_with("Error:") {
|
if result.starts_with("Error:") {
|
||||||
@@ -171,11 +258,11 @@ pub async fn run_agent(
|
|||||||
consecutive_errors += 1;
|
consecutive_errors += 1;
|
||||||
} else {
|
} else {
|
||||||
consecutive_errors = 1;
|
consecutive_errors = 1;
|
||||||
last_tool = tool_name.to_string();
|
last_tool = tool_name.clone();
|
||||||
}
|
}
|
||||||
if consecutive_errors >= MAX_CONSECUTIVE_TOOL_ERRORS {
|
if consecutive_errors >= MAX_CONSECUTIVE_TOOL_ERRORS {
|
||||||
messages.push(ChatMessage::system(
|
messages.push(ChatMessage::system(
|
||||||
zesdex_domain::agent::prompt::error_recovery_note(tool_name, &result),
|
zesdex_domain::agent::prompt::error_recovery_note(&tool_name, &result),
|
||||||
));
|
));
|
||||||
consecutive_errors = 0;
|
consecutive_errors = 0;
|
||||||
}
|
}
|
||||||
@@ -183,15 +270,7 @@ pub async fn run_agent(
|
|||||||
consecutive_errors = 0;
|
consecutive_errors = 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
messages.push(ChatMessage::tool(
|
messages.push(ChatMessage::tool(id, truncate_tool_output(result)));
|
||||||
tc.id.clone(),
|
|
||||||
truncate_tool_output(result),
|
|
||||||
));
|
|
||||||
}
|
|
||||||
|
|
||||||
// Add assistant response if there was text content
|
|
||||||
if !content.is_empty() {
|
|
||||||
messages.push(ChatMessage::assistant(Some(content)));
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -208,3 +287,111 @@ pub async fn run_agent(
|
|||||||
"Subagent reached iteration limit ({MAX_ITERATIONS})"
|
"Subagent reached iteration limit ({MAX_ITERATIONS})"
|
||||||
))
|
))
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
use super::*;
|
||||||
|
use crate::tools::ToolCtxBuilder;
|
||||||
|
use serde_json::json;
|
||||||
|
|
||||||
|
/// A deterministic mock tool whose `run` returns its own name (opting into
|
||||||
|
/// an optional sleep to make parallel-vs-sequential observable).
|
||||||
|
struct MockTool {
|
||||||
|
name: &'static str,
|
||||||
|
sleep_ms: u64,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl MockTool {
|
||||||
|
fn new(name: &'static str, sleep_ms: u64) -> Self {
|
||||||
|
Self { name, sleep_ms }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
impl Tool for MockTool {
|
||||||
|
fn name(&self) -> &'static str {
|
||||||
|
self.name
|
||||||
|
}
|
||||||
|
fn description(&self) -> &'static str {
|
||||||
|
"mock tool for tests"
|
||||||
|
}
|
||||||
|
fn parameters(&self) -> Value {
|
||||||
|
json!({"type":"object","properties":{}})
|
||||||
|
}
|
||||||
|
fn run(&self, _ctx: &ToolCtx, _args: &Value) -> Result<String> {
|
||||||
|
if self.sleep_ms > 0 {
|
||||||
|
std::thread::sleep(std::time::Duration::from_millis(self.sleep_ms));
|
||||||
|
}
|
||||||
|
Ok(self.name.to_string())
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn tc(name: &str, id: usize) -> zesdex_domain::core::ToolCall {
|
||||||
|
zesdex_domain::core::ToolCall {
|
||||||
|
id: format!("call_{id}"),
|
||||||
|
type_: "function".to_string(),
|
||||||
|
function: zesdex_domain::core::ToolFunction {
|
||||||
|
name: name.to_string(),
|
||||||
|
arguments: serde_json::Value::String(String::new()),
|
||||||
|
},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn ctx() -> ToolCtx {
|
||||||
|
ToolCtxBuilder::default().build()
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn parallel_batch_preserves_original_order() {
|
||||||
|
let tools: Vec<Box<dyn Tool>> = vec![
|
||||||
|
Box::new(MockTool::new("read", 0)),
|
||||||
|
Box::new(MockTool::new("grep", 0)),
|
||||||
|
];
|
||||||
|
let calls = vec![tc("read", 1), tc("grep", 2), tc("read", 3)];
|
||||||
|
|
||||||
|
let results = execute_tool_batch(&tools, &ctx(), &calls);
|
||||||
|
|
||||||
|
// Results keep the assistant's original call order.
|
||||||
|
let names: Vec<&str> = results.iter().map(|(_, n, _)| n.as_str()).collect();
|
||||||
|
assert_eq!(names, vec!["read", "grep", "read"]);
|
||||||
|
// IDs follow the same original order (ordering contract).
|
||||||
|
let ids: Vec<&str> = results.iter().map(|(id, _, _)| id.as_str()).collect();
|
||||||
|
assert_eq!(ids, vec!["call_1", "call_2", "call_3"]);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn parallel_read_batch_is_faster_than_sequential() {
|
||||||
|
// Both reads sleep 30ms each. Parallel should finish ~30ms (both run
|
||||||
|
// at once), sequential would take ~60ms.
|
||||||
|
let tools: Vec<Box<dyn Tool>> = vec![Box::new(MockTool::new("read", 30))];
|
||||||
|
let calls = vec![tc("read", 1), tc("read", 2)];
|
||||||
|
|
||||||
|
let started = std::time::Instant::now();
|
||||||
|
let results = execute_tool_batch(&tools, &ctx(), &calls);
|
||||||
|
let elapsed = started.elapsed();
|
||||||
|
|
||||||
|
assert_eq!(results.len(), 2);
|
||||||
|
assert!(
|
||||||
|
elapsed < std::time::Duration::from_millis(55),
|
||||||
|
"parallel read batch took {elapsed:?}, expected concurrent execution"
|
||||||
|
);
|
||||||
|
assert!(elapsed >= std::time::Duration::from_millis(25));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn mutating_tool_forces_sequential_batch() {
|
||||||
|
// A batch containing a mutating tool ("write") must NOT run in
|
||||||
|
// parallel — the single 30ms read runs alone, then the write runs.
|
||||||
|
let tools: Vec<Box<dyn Tool>> = vec![
|
||||||
|
Box::new(MockTool::new("read", 30)),
|
||||||
|
Box::new(MockTool::new("write", 0)),
|
||||||
|
];
|
||||||
|
let calls = vec![tc("read", 1), tc("write", 2)];
|
||||||
|
|
||||||
|
let results = execute_tool_batch(&tools, &ctx(), &calls);
|
||||||
|
|
||||||
|
let names: Vec<&str> = results.iter().map(|(_, n, _)| n.as_str()).collect();
|
||||||
|
assert_eq!(names, vec!["read", "write"]);
|
||||||
|
let ids: Vec<&str> = results.iter().map(|(id, _, _)| id.as_str()).collect();
|
||||||
|
assert_eq!(ids, vec!["call_1", "call_2"]);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
@@ -66,6 +66,14 @@ impl ToolCtxBuilder {
|
|||||||
self.session_dir = v;
|
self.session_dir = v;
|
||||||
self
|
self
|
||||||
}
|
}
|
||||||
|
pub fn memory_dir(mut self, v: PathBuf) -> Self {
|
||||||
|
self.memory_dir = v;
|
||||||
|
self
|
||||||
|
}
|
||||||
|
pub fn worktrees_dir(mut self, v: PathBuf) -> Self {
|
||||||
|
self.worktrees_dir = v;
|
||||||
|
self
|
||||||
|
}
|
||||||
pub fn workspaces(mut self, v: Vec<PathBuf>) -> Self {
|
pub fn workspaces(mut self, v: Vec<PathBuf>) -> Self {
|
||||||
self.workspaces = v;
|
self.workspaces = v;
|
||||||
self
|
self
|
||||||
|
|||||||
@@ -15,6 +15,13 @@ impl InfrastructureToolExecutor {
|
|||||||
tools: all_tools(),
|
tools: all_tools(),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Whether a tool is read-only and safe to execute concurrently with
|
||||||
|
/// other parallel-safe tools. Delegates to the registry so the main
|
||||||
|
/// turn loop and subagent engine share one source of truth.
|
||||||
|
pub fn is_parallel_safe(tool_name: &str) -> bool {
|
||||||
|
crate::tools::tool_is_parallel_safe(tool_name)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
impl ToolExecutor for InfrastructureToolExecutor {
|
impl ToolExecutor for InfrastructureToolExecutor {
|
||||||
@@ -37,4 +44,8 @@ impl ToolExecutor for InfrastructureToolExecutor {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn is_parallel_safe(&self, tool_name: &str) -> bool {
|
||||||
|
Self::is_parallel_safe(tool_name)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -43,7 +43,8 @@ impl Tool for Forget {
|
|||||||
let name = crate::tools::arg_str(args, "name")?;
|
let name = crate::tools::arg_str(args, "name")?;
|
||||||
info!(name, "forget invoked");
|
info!(name, "forget invoked");
|
||||||
let repo = crate::persistence::cms::memory_repo::MarkdownMemoryRepository::new();
|
let repo = crate::persistence::cms::memory_repo::MarkdownMemoryRepository::new();
|
||||||
repo.delete(&ctx.memory_dir, &name)?;
|
let memory_dir = crate::tools::memory::resolve_memory_dir(&ctx.memory_dir);
|
||||||
|
repo.delete(&memory_dir, &name)?;
|
||||||
info!(name, "memory deleted");
|
info!(name, "memory deleted");
|
||||||
Ok(format!("Memory '{}' deleted", name))
|
Ok(format!("Memory '{}' deleted", name))
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,5 +1,21 @@
|
|||||||
//! Memory management tools — remember, recall, forget.
|
//! Memory management tools — remember, recall, forget.
|
||||||
|
|
||||||
|
use std::path::PathBuf;
|
||||||
|
|
||||||
pub mod forget;
|
pub mod forget;
|
||||||
pub mod recall;
|
pub mod recall;
|
||||||
pub mod remember;
|
pub mod remember;
|
||||||
|
|
||||||
|
/// Resolve the directory the memory tools should read/write.
|
||||||
|
///
|
||||||
|
/// Prefer an explicitly-configured `ToolCtx.memory_dir`. If that is empty
|
||||||
|
/// (a `ToolCtx` is often built without setting `memory_dir`), fall back to
|
||||||
|
/// the canonical persistent memory location from `Store` so memories are not
|
||||||
|
/// silently written into the current working directory.
|
||||||
|
pub fn resolve_memory_dir(ctx_memory_dir: &std::path::Path) -> PathBuf {
|
||||||
|
if ctx_memory_dir.as_os_str().is_empty() {
|
||||||
|
zesdex_domain::core::Store::new().memory_dir
|
||||||
|
} else {
|
||||||
|
ctx_memory_dir.to_path_buf()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
@@ -45,21 +45,132 @@ impl Tool for Recall {
|
|||||||
#[instrument(skip(self, ctx, args))]
|
#[instrument(skip(self, ctx, args))]
|
||||||
fn run(&self, ctx: &ToolCtx, args: &Value) -> Result<String> {
|
fn run(&self, ctx: &ToolCtx, args: &Value) -> Result<String> {
|
||||||
let repo = crate::persistence::cms::memory_repo::MarkdownMemoryRepository::new();
|
let repo = crate::persistence::cms::memory_repo::MarkdownMemoryRepository::new();
|
||||||
|
let memory_dir = crate::tools::memory::resolve_memory_dir(&ctx.memory_dir);
|
||||||
|
|
||||||
let specific_name = args.get("name").and_then(|v| v.as_str());
|
let specific_name = args.get("name").and_then(|v| v.as_str());
|
||||||
|
let search = args.get("search").and_then(|v| v.as_str());
|
||||||
|
|
||||||
if let Some(name) = specific_name {
|
if let Some(name) = specific_name {
|
||||||
info!(name, "recall loading specific memory");
|
info!(name, "recall loading specific memory");
|
||||||
let memory = repo.load(&ctx.memory_dir, name)?;
|
let memory = repo.load(&memory_dir, name)?;
|
||||||
Ok(serde_json::to_string_pretty(&memory)?)
|
return Ok(serde_json::to_string_pretty(&memory)?);
|
||||||
} else {
|
}
|
||||||
|
|
||||||
|
if let Some(query) = search {
|
||||||
|
let query = query.trim().to_lowercase();
|
||||||
|
info!(search = %query, "recall searching memories");
|
||||||
|
if query.is_empty() {
|
||||||
|
return Ok("Search query is empty".to_string());
|
||||||
|
}
|
||||||
|
let names = repo.list(&memory_dir)?;
|
||||||
|
let mut matches: Vec<String> = Vec::new();
|
||||||
|
for name in &names {
|
||||||
|
// Load each memory and match against name/description/content.
|
||||||
|
if let Ok(m) = repo.load(&memory_dir, name) {
|
||||||
|
let haystack =
|
||||||
|
format!("{} {} {}", m.name, m.description, m.content).to_lowercase();
|
||||||
|
if haystack.contains(&query) {
|
||||||
|
matches.push(m.name);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if matches.is_empty() {
|
||||||
|
return Ok(format!("No memories match '{query}'"));
|
||||||
|
}
|
||||||
|
return Ok(format!(
|
||||||
|
"Memories matching '{query}' ({}):\n{}",
|
||||||
|
matches.len(),
|
||||||
|
matches.join("\n")
|
||||||
|
));
|
||||||
|
}
|
||||||
|
|
||||||
info!("recall listing all memories");
|
info!("recall listing all memories");
|
||||||
let names = repo.list(&ctx.memory_dir)?;
|
let names = repo.list(&memory_dir)?;
|
||||||
if names.is_empty() {
|
if names.is_empty() {
|
||||||
info!("no memories found");
|
info!("no memories found");
|
||||||
return Ok("No memories saved yet".to_string());
|
return Ok("No memories saved yet".to_string());
|
||||||
}
|
}
|
||||||
Ok(format!("Available memories:\n{}", names.join("\n")))
|
Ok(format!("Available memories:\n{}", names.join("\n")))
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
use super::*;
|
||||||
|
use crate::tools::ToolCtxBuilder;
|
||||||
|
use zesdex_domain::cms::MemoryRepository;
|
||||||
|
|
||||||
|
fn save_mem(name: &str, description: &str, content: &str, dir: &std::path::Path) {
|
||||||
|
let repo = crate::persistence::cms::memory_repo::MarkdownMemoryRepository::new();
|
||||||
|
let memory = zesdex_domain::cms::Memory {
|
||||||
|
name: name.to_string(),
|
||||||
|
description: description.to_string(),
|
||||||
|
content: content.to_string(),
|
||||||
|
kind: "reference".to_string(),
|
||||||
|
created_at: 0,
|
||||||
|
updated_at: 0,
|
||||||
|
outcome: None,
|
||||||
|
lifecycle: "active".to_string(),
|
||||||
|
scope: None,
|
||||||
|
before_snippet: None,
|
||||||
|
after_snippet: None,
|
||||||
|
provenances: Vec::new(),
|
||||||
|
};
|
||||||
|
repo.save(dir, &memory).unwrap();
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn search_filters_memories_by_keyword() {
|
||||||
|
let dir = std::env::temp_dir().join(format!("zdx-mem-test-{}", uuid::Uuid::new_v4()));
|
||||||
|
std::fs::create_dir_all(&dir).unwrap();
|
||||||
|
save_mem(
|
||||||
|
"rust-concurrency",
|
||||||
|
"tokio spawn patterns",
|
||||||
|
"how to use async tasks",
|
||||||
|
&dir,
|
||||||
|
);
|
||||||
|
save_mem(
|
||||||
|
"docker-deploy",
|
||||||
|
"deploy via compose",
|
||||||
|
"container orchestration",
|
||||||
|
&dir,
|
||||||
|
);
|
||||||
|
|
||||||
|
let tool_ctx = ToolCtxBuilder::default().memory_dir(dir.clone()).build();
|
||||||
|
let args = serde_json::json!({ "search": "tokio" });
|
||||||
|
|
||||||
|
let out = Recall.run(&tool_ctx, &args).unwrap();
|
||||||
|
assert!(
|
||||||
|
out.contains("rust-concurrency"),
|
||||||
|
"should match rust-concurrency, got: {out}"
|
||||||
|
);
|
||||||
|
assert!(
|
||||||
|
!out.contains("docker-deploy"),
|
||||||
|
"docker-deploy should not match tokio"
|
||||||
|
);
|
||||||
|
|
||||||
|
// A query with no match reports so.
|
||||||
|
let no_match = Recall
|
||||||
|
.run(&tool_ctx, &serde_json::json!({ "search": "zzzznope" }))
|
||||||
|
.unwrap();
|
||||||
|
assert!(no_match.contains("No memories match"), "{no_match}");
|
||||||
|
|
||||||
|
std::fs::remove_dir_all(&dir).ok();
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn resolve_memory_dir_falls_back_to_store_when_empty() {
|
||||||
|
// An empty ToolCtx.memory_dir is resolved to the canonical Store path.
|
||||||
|
let resolved = crate::tools::memory::resolve_memory_dir(std::path::Path::new(""));
|
||||||
|
assert!(!resolved.as_os_str().is_empty());
|
||||||
|
assert!(
|
||||||
|
resolved.ends_with("memory"),
|
||||||
|
"expected memory dir, got {resolved:?}"
|
||||||
|
);
|
||||||
|
|
||||||
|
// An explicit memory_dir is preserved.
|
||||||
|
let explicit =
|
||||||
|
crate::tools::memory::resolve_memory_dir(std::path::Path::new("/tmp/custom-memory"));
|
||||||
|
assert_eq!(explicit, std::path::Path::new("/tmp/custom-memory"));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -81,7 +81,8 @@ impl Tool for Remember {
|
|||||||
};
|
};
|
||||||
|
|
||||||
let repo = crate::persistence::cms::memory_repo::MarkdownMemoryRepository::new();
|
let repo = crate::persistence::cms::memory_repo::MarkdownMemoryRepository::new();
|
||||||
repo.save(&ctx.memory_dir, &memory)?;
|
let memory_dir = crate::tools::memory::resolve_memory_dir(&ctx.memory_dir);
|
||||||
|
repo.save(&memory_dir, &memory)?;
|
||||||
|
|
||||||
info!(name, "memory saved");
|
info!(name, "memory saved");
|
||||||
Ok(format!("Memory '{}' saved", name))
|
Ok(format!("Memory '{}' saved", name))
|
||||||
|
|||||||
@@ -59,7 +59,7 @@ pub mod workflow;
|
|||||||
// like `crate::tools::{Tool, ToolCtx}` continue to work.
|
// like `crate::tools::{Tool, ToolCtx}` continue to work.
|
||||||
pub use context::{ToolCtx, ToolCtxBuilder};
|
pub use context::{ToolCtx, ToolCtxBuilder};
|
||||||
pub use graduated::{check_graduated_checks, GraduatedCheck};
|
pub use graduated::{check_graduated_checks, GraduatedCheck};
|
||||||
pub use registry::{all_tools, tool_defs, tool_is_risky};
|
pub use registry::{all_tools, tool_defs, tool_is_parallel_safe, tool_is_risky};
|
||||||
pub use util::{arg_str, execute_cmd, log_write_edit_tool, resolve_path};
|
pub use util::{arg_str, execute_cmd, log_write_edit_tool, resolve_path};
|
||||||
|
|
||||||
/// Common interface every agent-invocable tool implements.
|
/// Common interface every agent-invocable tool implements.
|
||||||
|
|||||||
@@ -52,6 +52,34 @@ pub fn tool_is_risky(name: &str) -> bool {
|
|||||||
matches!(name, "write" | "delete" | "edit" | "bash" | "git_operator")
|
matches!(name, "write" | "delete" | "edit" | "bash" | "git_operator")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Whether a tool by name is read-only and therefore safe to run *in
|
||||||
|
/// parallel* with other tool calls within the same assistant message.
|
||||||
|
///
|
||||||
|
/// Read-only tools only inspect the workspace (read files, grep, glob,
|
||||||
|
/// semantic search, list symbols, recall memory, web search, directory
|
||||||
|
/// listing). They have no side effects, so concurrent execution cannot
|
||||||
|
/// create data races or conflicting writes.
|
||||||
|
///
|
||||||
|
/// Everything else (edits, writes, deletes, shell, git, planning, memory
|
||||||
|
/// writes, agent/spawn orchestration) stays sequential to preserve
|
||||||
|
/// correctness.
|
||||||
|
pub fn tool_is_parallel_safe(name: &str) -> bool {
|
||||||
|
matches!(
|
||||||
|
name,
|
||||||
|
"read"
|
||||||
|
| "grep"
|
||||||
|
| "glob"
|
||||||
|
| "semantic_search"
|
||||||
|
| "list_symbols"
|
||||||
|
| "web_search"
|
||||||
|
| "recall"
|
||||||
|
| "dir_list"
|
||||||
|
| "pong"
|
||||||
|
| "seq_think"
|
||||||
|
| "dir_cache_update"
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
/// Convert a list of tools into provider-facing `ToolDef` request schema.
|
/// Convert a list of tools into provider-facing `ToolDef` request schema.
|
||||||
pub fn tool_defs(tools: &[Box<dyn super::Tool>]) -> Vec<zesdex_domain::core::ToolDef> {
|
pub fn tool_defs(tools: &[Box<dyn super::Tool>]) -> Vec<zesdex_domain::core::ToolDef> {
|
||||||
tools
|
tools
|
||||||
@@ -66,3 +94,59 @@ pub fn tool_defs(tools: &[Box<dyn super::Tool>]) -> Vec<zesdex_domain::core::Too
|
|||||||
})
|
})
|
||||||
.collect()
|
.collect()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
use super::*;
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn read_only_tools_are_parallel_safe() {
|
||||||
|
for name in [
|
||||||
|
"read",
|
||||||
|
"grep",
|
||||||
|
"glob",
|
||||||
|
"semantic_search",
|
||||||
|
"list_symbols",
|
||||||
|
"web_search",
|
||||||
|
"recall",
|
||||||
|
"dir_list",
|
||||||
|
"pong",
|
||||||
|
"seq_think",
|
||||||
|
"dir_cache_update",
|
||||||
|
] {
|
||||||
|
assert!(
|
||||||
|
tool_is_parallel_safe(name),
|
||||||
|
"{name} should be parallel-safe"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn mutating_and_shell_tools_are_not_parallel_safe() {
|
||||||
|
for name in [
|
||||||
|
"edit",
|
||||||
|
"write",
|
||||||
|
"delete",
|
||||||
|
"bash",
|
||||||
|
"git_operator",
|
||||||
|
"git_worktree",
|
||||||
|
"remember",
|
||||||
|
"forget",
|
||||||
|
"todowrite",
|
||||||
|
"todofinish",
|
||||||
|
"plan_enter",
|
||||||
|
"plan_ready",
|
||||||
|
"workflow_run",
|
||||||
|
"hive_mind",
|
||||||
|
"spawn_agents",
|
||||||
|
"spawn_pipeline",
|
||||||
|
"parallel_delegate",
|
||||||
|
"explore_codebase",
|
||||||
|
] {
|
||||||
|
assert!(
|
||||||
|
!tool_is_parallel_safe(name),
|
||||||
|
"{name} should NOT be parallel-safe"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
@@ -9,7 +9,6 @@ use anyhow::Result;
|
|||||||
use serde_json::{json, Value};
|
use serde_json::{json, Value};
|
||||||
use tracing::{debug, info, instrument, warn};
|
use tracing::{debug, info, instrument, warn};
|
||||||
|
|
||||||
use crate::llm::provider::LlmClient;
|
|
||||||
use crate::tools::{arg_str, Tool, ToolCtx};
|
use crate::tools::{arg_str, Tool, ToolCtx};
|
||||||
use crate::workflow::engine::execution::execute_workflow;
|
use crate::workflow::engine::execution::execute_workflow;
|
||||||
use crate::workflow::hive_mind::cycle::execute_cycle;
|
use crate::workflow::hive_mind::cycle::execute_cycle;
|
||||||
@@ -60,14 +59,8 @@ impl Tool for WorkflowRun {
|
|||||||
phase_names.join(", ")
|
phase_names.join(", ")
|
||||||
);
|
);
|
||||||
|
|
||||||
let llm_client = LlmClient::new(
|
|
||||||
crate::llm::provider::DEFAULT_API_KEY.to_string(),
|
|
||||||
zesdex_domain::agent::defaults::DEFAULT_MODEL.to_string(),
|
|
||||||
None,
|
|
||||||
);
|
|
||||||
let rt = crate::runtime::runtime();
|
let rt = crate::runtime::runtime();
|
||||||
let result: Vec<String> =
|
let result: Vec<String> = rt.block_on(async { execute_workflow(&script, ctx).await })?;
|
||||||
rt.block_on(async { execute_workflow(&script, ctx, &llm_client).await })?;
|
|
||||||
|
|
||||||
info!(phase_count = result.len(), "Workflow completed");
|
info!(phase_count = result.len(), "Workflow completed");
|
||||||
Ok(format!(
|
Ok(format!(
|
||||||
|
|||||||
@@ -221,7 +221,14 @@ pub fn build_rich_context(root: &Path) -> String {
|
|||||||
));
|
));
|
||||||
|
|
||||||
// 2. Custom Rules
|
// 2. Custom Rules
|
||||||
let rule_files = [".cursorrules", ".zesdexrules", "claude.md", "agent.md"];
|
let rule_files = [
|
||||||
|
"AGENTS.md",
|
||||||
|
"CLAUDE.md",
|
||||||
|
".cursorrules",
|
||||||
|
".zesdexrules",
|
||||||
|
"claude.md",
|
||||||
|
"agent.md",
|
||||||
|
];
|
||||||
for file in rule_files {
|
for file in rule_files {
|
||||||
let p = root.join(file);
|
let p = root.join(file);
|
||||||
if let Ok(content) = std::fs::read_to_string(&p) {
|
if let Ok(content) = std::fs::read_to_string(&p) {
|
||||||
@@ -268,7 +275,7 @@ pub fn build_rich_context(root: &Path) -> String {
|
|||||||
let p = root.join(file);
|
let p = root.join(file);
|
||||||
if let Ok(content) = std::fs::read_to_string(&p) {
|
if let Ok(content) = std::fs::read_to_string(&p) {
|
||||||
let snippet = if content.len() > 1500 {
|
let snippet = if content.len() > 1500 {
|
||||||
format!("{}\n... (truncated)", &content[..1500])
|
format!("{}\n... (truncated)", truncate_chars(&content, 1500))
|
||||||
} else {
|
} else {
|
||||||
content
|
content
|
||||||
};
|
};
|
||||||
@@ -294,7 +301,7 @@ pub fn build_rich_context(root: &Path) -> String {
|
|||||||
let readme_path = root.join("README.md");
|
let readme_path = root.join("README.md");
|
||||||
if let Ok(content) = std::fs::read_to_string(&readme_path) {
|
if let Ok(content) = std::fs::read_to_string(&readme_path) {
|
||||||
let snippet = if content.len() > 1000 {
|
let snippet = if content.len() > 1000 {
|
||||||
format!("{}\n... (truncated)", &content[..1000])
|
format!("{}\n... (truncated)", truncate_chars(&content, 1000))
|
||||||
} else {
|
} else {
|
||||||
content
|
content
|
||||||
};
|
};
|
||||||
@@ -341,3 +348,53 @@ pub fn build_rich_context(root: &Path) -> String {
|
|||||||
|
|
||||||
ctx.trim_end().to_string()
|
ctx.trim_end().to_string()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Truncate a string to at most `max_chars` **characters**, never cutting a
|
||||||
|
/// multi-byte UTF-8 code point in half.
|
||||||
|
///
|
||||||
|
/// `&s[..n]` with `n` a raw byte index panics when `n` lands inside a
|
||||||
|
/// multi-byte character (e.g. an emoji, `→`, or CJK in a README/diff). This
|
||||||
|
/// helper slices on character boundaries so content is safely capped at a
|
||||||
|
/// byte budget while remaining valid UTF-8.
|
||||||
|
pub fn truncate_chars(s: &str, max_chars: usize) -> String {
|
||||||
|
if s.chars().count() <= max_chars {
|
||||||
|
return s.to_string();
|
||||||
|
}
|
||||||
|
s.chars().take(max_chars).collect()
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
use super::*;
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn truncate_chars_leaves_short_strings_unchanged() {
|
||||||
|
assert_eq!(truncate_chars("short", 100), "short");
|
||||||
|
assert_eq!(truncate_chars("", 5), "");
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn truncate_chars_cuts_to_max_chars() {
|
||||||
|
assert_eq!(truncate_chars("hello world", 5), "hello");
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn truncate_chars_never_splits_multibyte_utf8() {
|
||||||
|
// 4 chars each: '→' is 3 bytes. Byte-slicing at 5 would panic; char
|
||||||
|
// slicing must not.
|
||||||
|
let s = "a→b→c→d";
|
||||||
|
let t = truncate_chars(s, 5);
|
||||||
|
assert_eq!(t, "a→b→c");
|
||||||
|
assert!(t.chars().count() <= 5);
|
||||||
|
// No replacement char must appear (valid UTF-8 preserved).
|
||||||
|
assert!(!t.contains('\u{FFFD}'));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn truncate_chars_handles_emoji() {
|
||||||
|
let s = "🚀🚀🚀🚀";
|
||||||
|
let t = truncate_chars(s, 2);
|
||||||
|
assert_eq!(t, "🚀🚀");
|
||||||
|
assert!(t.chars().count() == 2);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
@@ -3,7 +3,6 @@
|
|||||||
use anyhow::Result;
|
use anyhow::Result;
|
||||||
use tracing::{info, instrument};
|
use tracing::{info, instrument};
|
||||||
|
|
||||||
use crate::llm::provider::LlmClient;
|
|
||||||
use crate::tools::ToolCtx;
|
use crate::tools::ToolCtx;
|
||||||
use crate::workflow::engine::primitives::execute_primitive;
|
use crate::workflow::engine::primitives::execute_primitive;
|
||||||
use zesdex_domain::workflow::WorkflowScript;
|
use zesdex_domain::workflow::WorkflowScript;
|
||||||
@@ -11,12 +10,8 @@ use zesdex_domain::workflow::WorkflowScript;
|
|||||||
/// Execute each phase of a workflow script sequentially.
|
/// Execute each phase of a workflow script sequentially.
|
||||||
///
|
///
|
||||||
/// Flow: for each phase → execute_primitive → collect result.
|
/// Flow: for each phase → execute_primitive → collect result.
|
||||||
#[instrument(skip(tool_ctx, _llm_client))]
|
#[instrument(skip(tool_ctx))]
|
||||||
pub async fn execute_workflow(
|
pub async fn execute_workflow(script: &WorkflowScript, tool_ctx: &ToolCtx) -> Result<Vec<String>> {
|
||||||
script: &WorkflowScript,
|
|
||||||
tool_ctx: &ToolCtx,
|
|
||||||
_llm_client: &LlmClient,
|
|
||||||
) -> Result<Vec<String>> {
|
|
||||||
info!(
|
info!(
|
||||||
"Executing workflow: {} ({} phases)",
|
"Executing workflow: {} ({} phases)",
|
||||||
script.name,
|
script.name,
|
||||||
|
|||||||
@@ -1,28 +1,128 @@
|
|||||||
//! Consensus synthesis — reconciles multiple node outputs into one assessment.
|
//! Consensus synthesis — reconciles multiple node outputs into one assessment.
|
||||||
|
//!
|
||||||
|
//! Flow: load settings → resolve LLM credentials → ask the model to distill the
|
||||||
|
//! node outputs into a single consensus (conflicts, agreements, key findings)
|
||||||
|
//! → return the synthesized text. If the LLM call fails for any reason, we
|
||||||
|
//! degrade gracefully to a concatenation-based summary so consensus synthesis
|
||||||
|
//! never breaks the surrounding hive-mind cycle (mirrors the isolated-errors
|
||||||
|
//! philosophy used for the nodes themselves).
|
||||||
|
|
||||||
use anyhow::Result;
|
use anyhow::Result;
|
||||||
use tracing::info;
|
use tracing::{info, warn};
|
||||||
|
|
||||||
use crate::tools::ToolCtx;
|
use zesdex_domain::cms::{AppConfigRepository, SettingsRepository};
|
||||||
|
use zesdex_domain::core::message::ChatMessage;
|
||||||
|
use zesdex_domain::core::Store;
|
||||||
use zesdex_domain::workflow::NodeOutput;
|
use zesdex_domain::workflow::NodeOutput;
|
||||||
|
|
||||||
/// Synthesize a consensus from all node outputs.
|
use crate::persistence::{JsonAppConfigRepository, JsonSettingsRepository};
|
||||||
|
use crate::tools::ToolCtx;
|
||||||
|
|
||||||
|
/// Maximum characters of node output to feed into the synthesis prompt per node.
|
||||||
|
/// Keeps the prompt bounded so a huge/talkative node cannot blow up the request.
|
||||||
|
const MAX_NODE_OUTPUT_CHARS: usize = 4000;
|
||||||
|
|
||||||
|
/// Synthesize a consensus from all node outputs using the LLM.
|
||||||
///
|
///
|
||||||
/// Flow: combine node outputs → return consensus text.
|
/// Flow: combine node outputs → ask the model to reconcile them into a single
|
||||||
/// Uses simple concatenation-based synthesis (avoids LLM call dependency).
|
/// consensus → return the synthesized text. Falls back to a plain
|
||||||
|
/// concatenation summary if the LLM is unreachable or the call fails.
|
||||||
pub async fn synthesize_consensus(nodes: &[NodeOutput], _tool_ctx: &ToolCtx) -> Result<String> {
|
pub async fn synthesize_consensus(nodes: &[NodeOutput], _tool_ctx: &ToolCtx) -> Result<String> {
|
||||||
info!("Synthesizing consensus from {} nodes", nodes.len());
|
info!("Synthesizing consensus from {} nodes", nodes.len());
|
||||||
|
|
||||||
|
let combined = build_combined_body(nodes);
|
||||||
|
|
||||||
|
// 1. Resolve LLM credentials (same source of truth as execute_cycle).
|
||||||
|
let store = Store::new();
|
||||||
|
let settings = JsonSettingsRepository::new()
|
||||||
|
.load(&store.base_dir)
|
||||||
|
.unwrap_or_default();
|
||||||
|
let app_config = JsonAppConfigRepository::new()
|
||||||
|
.load(&store.base_dir)
|
||||||
|
.unwrap_or_default();
|
||||||
|
|
||||||
|
let (provider, model) =
|
||||||
|
crate::subagent::provider::resolve_subagent_provider(&settings, &app_config);
|
||||||
|
let base_url = app_config
|
||||||
|
.providers
|
||||||
|
.get(&provider)
|
||||||
|
.map(|p| p.api_base.clone())
|
||||||
|
.unwrap_or_else(|| zesdex_domain::agent::defaults::DEFAULT_API_BASE.to_string());
|
||||||
|
let api_key = crate::llm::provider::resolve_api_key(&settings, &app_config);
|
||||||
|
|
||||||
|
let client = crate::llm::provider::LlmClient::new(api_key, model, Some(base_url));
|
||||||
|
|
||||||
|
// 2. Build the synthesis prompt.
|
||||||
|
let system_msg = ChatMessage::system(
|
||||||
|
"You are a consensus synthesizer for a multi-agent hive mind. \
|
||||||
|
Several independent nodes analysed a problem and produced the outputs \
|
||||||
|
below. Distill them into ONE coherent consensus report with these \
|
||||||
|
sections:\n\
|
||||||
|
- AGREEMENTS: points multiple nodes converge on.\n\
|
||||||
|
- CONFLICTS: contradictory conclusions, with which node(s) support each side.\n\
|
||||||
|
- KEY FINDINGS: the most important, actionable takeaways.\n\
|
||||||
|
- RECOMMENDATION: a single recommended next action, or 'no clear consensus' \
|
||||||
|
if the outputs are too divergent.\n\
|
||||||
|
Be concise and factual. If a node errored, note it and ignore its content.\n\
|
||||||
|
Do not invent facts not present in the node outputs.",
|
||||||
|
);
|
||||||
|
let user_msg = ChatMessage::user(format!(
|
||||||
|
"Consolidate these {} node outputs into a single consensus:\n\n{}",
|
||||||
|
nodes.len(),
|
||||||
|
combined
|
||||||
|
));
|
||||||
|
|
||||||
|
// 3. Call the model and gracefully degrade on failure.
|
||||||
|
match call_consensus(&client, &[system_msg, user_msg]).await {
|
||||||
|
Ok(text) => {
|
||||||
|
let trimmed = text.trim();
|
||||||
|
if trimmed.is_empty() {
|
||||||
|
warn!("consensus LLM returned empty output; falling back to concat summary");
|
||||||
|
Ok(concat_summary(nodes))
|
||||||
|
} else {
|
||||||
|
Ok(format!(
|
||||||
|
"# Consensus Synthesis\n\n\
|
||||||
|
Nodes synthesized: {}\n\n{}",
|
||||||
|
nodes.len(),
|
||||||
|
trimmed
|
||||||
|
))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
Err(e) => {
|
||||||
|
warn!(error = %e, "consensus LLM call failed; falling back to concat summary");
|
||||||
|
Ok(concat_summary(nodes))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Run the LLM consensus call and return the assistant text.
|
||||||
|
async fn call_consensus(
|
||||||
|
client: &crate::llm::provider::LlmClient,
|
||||||
|
messages: &[ChatMessage],
|
||||||
|
) -> Result<String> {
|
||||||
|
use zesdex_application::ports::ProviderService;
|
||||||
|
let (msg, _) = client.chat(messages, None, Some(1024), Some(0.3)).await?;
|
||||||
|
Ok(msg.content.unwrap_or_default())
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Build the concatenated node-output body for the prompt.
|
||||||
|
fn build_combined_body(nodes: &[NodeOutput]) -> String {
|
||||||
let mut combined = String::new();
|
let mut combined = String::new();
|
||||||
for node in nodes {
|
for node in nodes {
|
||||||
|
let output = crate::utils::truncate_chars(&node.output, MAX_NODE_OUTPUT_CHARS);
|
||||||
combined.push_str(&format!(
|
combined.push_str(&format!(
|
||||||
"\n## {} — {}\n\n{}\n",
|
"\n## {} — {}\n{}\n",
|
||||||
node.id, node.directive, node.output
|
node.id, node.directive, output
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
|
combined
|
||||||
|
}
|
||||||
|
|
||||||
Ok(format!(
|
/// Fallback: a plain concatenation summary (the behaviour of the original stub).
|
||||||
"# Consensus Synthesis\n\
|
fn concat_summary(nodes: &[NodeOutput]) -> String {
|
||||||
|
let combined = build_combined_body(nodes);
|
||||||
|
format!(
|
||||||
|
"# Consensus Synthesis\n\n\
|
||||||
Nodes synthesized: {}\n\n\
|
Nodes synthesized: {}\n\n\
|
||||||
## Summary\n\
|
## Summary\n\
|
||||||
The following node outputs were collected:\n\
|
The following node outputs were collected:\n\
|
||||||
@@ -31,5 +131,47 @@ pub async fn synthesize_consensus(nodes: &[NodeOutput], _tool_ctx: &ToolCtx) ->
|
|||||||
Review the individual node outputs above for detailed findings.",
|
Review the individual node outputs above for detailed findings.",
|
||||||
nodes.len(),
|
nodes.len(),
|
||||||
combined
|
combined
|
||||||
))
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
use super::*;
|
||||||
|
use zesdex_domain::workflow::NodeOutput;
|
||||||
|
|
||||||
|
fn node(id: &str, output: &str) -> NodeOutput {
|
||||||
|
NodeOutput {
|
||||||
|
id: id.to_string(),
|
||||||
|
directive: "directive".to_string(),
|
||||||
|
output: output.to_string(),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn build_combined_body_truncates_oversized_output() {
|
||||||
|
let long = "é".repeat(MAX_NODE_OUTPUT_CHARS + 500);
|
||||||
|
let body = build_combined_body(&[node("n1", &long)]);
|
||||||
|
// Must contain the header and a char-truncated (<= cap) payload without
|
||||||
|
// panicking on a multi-byte boundary.
|
||||||
|
assert!(body.contains("## n1"));
|
||||||
|
// Header "## n1 — directive\n" ~= 20 chars, so char count stays just above cap.
|
||||||
|
let char_count = body.chars().count();
|
||||||
|
assert!(
|
||||||
|
char_count <= MAX_NODE_OUTPUT_CHARS + 50,
|
||||||
|
"expected body near {MAX_NODE_OUTPUT_CHARS} chars, got {char_count}"
|
||||||
|
);
|
||||||
|
assert!(
|
||||||
|
char_count > 1000,
|
||||||
|
"expected a many-node output, got small: {char_count}"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn concat_summary_includes_all_node_ids() {
|
||||||
|
let nodes = vec![node("node-a", "a out"), node("node-b", "b out")];
|
||||||
|
let summary = concat_summary(&nodes);
|
||||||
|
assert!(summary.contains("node-a"));
|
||||||
|
assert!(summary.contains("node-b"));
|
||||||
|
assert!(summary.contains("Nodes synthesized: 2"));
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user