From 3a0d5745ea05b65d6a5604b6a693c50ce7e80501 Mon Sep 17 00:00:00 2001 From: Elysia <71698422+aiko-chan-ai@users.noreply.github.com> Date: Tue, 21 Jan 2025 02:11:19 +0700 Subject: [PATCH] refactor: remove extra traversing #10580 djs --- src/managers/GuildChannelManager.js | 2 +- src/managers/GuildMemberManager.js | 4 ++-- src/managers/GuildScheduledEventManager.js | 5 +---- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/managers/GuildChannelManager.js b/src/managers/GuildChannelManager.js index 58a1e56..20d3912 100644 --- a/src/managers/GuildChannelManager.js +++ b/src/managers/GuildChannelManager.js @@ -298,7 +298,7 @@ class GuildChannelManager extends CachedManager { if (data.lockPermissions) { if (parentId) { - const newParent = this.guild.channels.cache.get(parentId); + const newParent = this.cache.get(parentId); if (newParent?.type === 'GUILD_CATEGORY') { permission_overwrites = newParent.permissionOverwrites.cache.map(o => PermissionOverwrites.resolve(o, this.guild), diff --git a/src/managers/GuildMemberManager.js b/src/managers/GuildMemberManager.js index e643ed7..6e9f6ea 100644 --- a/src/managers/GuildMemberManager.js +++ b/src/managers/GuildMemberManager.js @@ -470,7 +470,7 @@ class GuildMemberManager extends CachedManager { * @returns {Promise} */ async addRole(user, role, reason) { - const userId = this.guild.members.resolveId(user); + const userId = this.resolveId(user); const roleId = this.guild.roles.resolveId(role); await this.client.api.guilds(this.guild.id).members(userId).roles(roleId).put({ reason }); @@ -486,7 +486,7 @@ class GuildMemberManager extends CachedManager { * @returns {Promise} */ async removeRole(user, role, reason) { - const userId = this.guild.members.resolveId(user); + const userId = this.resolveId(user); const roleId = this.guild.roles.resolveId(role); await this.client.api.guilds(this.guild.id).members(userId).roles(roleId).delete({ reason }); diff --git a/src/managers/GuildScheduledEventManager.js b/src/managers/GuildScheduledEventManager.js index d30fd07..8f50b19 100644 --- a/src/managers/GuildScheduledEventManager.js +++ b/src/managers/GuildScheduledEventManager.js @@ -174,10 +174,7 @@ class GuildScheduledEventManager extends CachedManager { return data.reduce( (coll, rawGuildScheduledEventData) => - coll.set( - rawGuildScheduledEventData.id, - this.guild.scheduledEvents._add(rawGuildScheduledEventData, options.cache), - ), + coll.set(rawGuildScheduledEventData.id, this._add(rawGuildScheduledEventData, options.cache)), new Collection(), ); }