refactor: use throw instead of Promise.reject

#10712 djs

src/client/voice/VoiceConnection.js

@@ -760,15 +760,15 @@ class VoiceConnection extends EventEmitter {
    * @param {UserResolvable} user Discord user
    * @returns {Promise<StreamConnectionReadonly>}
    */
-  joinStreamConnection(user) {
+  async joinStreamConnection(user) {
     const userId = this.client.users.resolveId(user);
     // Check if user is streaming
     if (!userId) {
-      return Promise.reject(new Error('VOICE_USER_MISSING'));
+      throw new Error('VOICE_USER_MISSING');
     }
     const voiceState = this.channel.guild?.voiceStates.cache.get(userId) || this.client.voiceStates.cache.get(userId);
     if (!voiceState || !voiceState.streaming) {
-      return Promise.reject(new Error('VOICE_USER_NOT_STREAMING'));
+      throw new Error('VOICE_USER_NOT_STREAMING');
     }
     // eslint-disable-next-line consistent-return
     return new Promise((resolve, reject) => {

src/client/voice/networking/VoiceWebSocket.js

@@ -104,12 +104,8 @@ class VoiceWebSocket extends EventEmitter {
    * @param {Object} packet The packet to send
    * @returns {Promise<string>}
    */
-  sendPacket(packet) {
-    try {
-      packet = JSON.stringify(packet);
-    } catch (error) {
-      return Promise.reject(error);
-    }
+  async sendPacket(packet) {
+    packet = JSON.stringify(packet);
     return this.send(packet);
   }