feat: enhance strictness of Rust compiler settings and improve code quality by treating warnings as errors

src/app/subagent/auto.rs

@@ -44,7 +44,7 @@ const QUICK_REVIEW_MAX_STEPS: usize = 2;
 const BG_SUBAGENT_MAX_STEPS: usize = 8;
 
 /// ─── Helpers ───
-
+///
 /// Check whether a file path is worth auto-reviewing (not config/lock/data).
 pub fn is_reviewable_path(path: &str) -> bool {
     let lower = path.to_lowercase();
@@ -81,7 +81,7 @@ fn is_production_code(path: &str) -> bool {
 }
 
 /// ─── Inline Quick Review (synchronous, feeds back to LLM) ───
-
+///
 /// Spawn a lightweight inline code review subagent for the given file.
 ///
 /// The subagent reads the file (read-only), checks for common issues,
@@ -143,7 +143,7 @@ pub fn spawn_quick_review(
 }
 
 /// ─── Background Subagent Spawners (async, report via SystemNote) ───
-
+///
 /// Spawn a background subagent that generates tests for modified files.
 ///
 /// Uses the test-generator prompt and has read-write access so it can

src/app/subagent/context.rs

@@ -2,7 +2,7 @@
 //! including the default read-only tool set for reviewer agents.
 
 use std::path::PathBuf;
-use std::sync::{Arc, Mutex, atomic::{AtomicBool, Ordering}};
+use std::sync::{Arc, Mutex, atomic::AtomicBool};
 use super::spawn::AgentDefinition;
 
 /// Default read-only tool names granted to `role == "reviewer"` agents.

src/app/subagent/division.rs

@@ -32,7 +32,7 @@ pub mod roles {
 }
 
 /// ─── Division Agent Definitions ───
-
+///
 /// Build the Strategy Division agent — chief architect and planner.
 ///
 /// Tools: read-only (read, grep, glob, search, lsp, plan, seqthink, recall)
@@ -172,16 +172,17 @@ pub fn documentation_division() -> AgentDefinition {
 }
 
 /// ─── Division Registry ───
-
+///
 /// A named division with its agent definition and display metadata.
 #[derive(Debug, Clone)]
-#[allow(dead_code)]
 pub struct Division {
     /// Display name for the division (e.g. "Strategy", "Engineering").
     pub name: &'static str,
     /// Role tag used for pipeline routing (matches `roles::*` constants).
+    #[allow(dead_code)]
     pub role: &'static str,
     /// One-line description of what this division does.
+    #[allow(dead_code)]
     pub description: &'static str,
     /// Agent definition with tools, prompt, and step budget.
     pub agent_def: AgentDefinition,

src/app/subagent/engine.rs

@@ -14,14 +14,6 @@ use crate::tool::{all_tools, tool_defs, tool_is_risky};
 use super::context::SubagentContext;
 use super::event::SubagentEvent;
 
-/// Upper bound on agent loop steps; effectively unbounded (`usize::MAX`).
-#[allow(dead_code)]
-pub const MAX_AGENT_STEPS: usize = usize::MAX;
-
-/// Maximum time a single tool call may block inside a subagent before
-/// being abandoned. Prevents a stuck tool from hanging the subagent loop.
-const SUBAGENT_TOOL_TIMEOUT_MS: u64 = 120_000;
-
 /// Maps a subagent's allowed tool names to concrete Tool trait objects and
 /// OpenAI-style tool definitions.
 ///