refactor: remove extra traversing

#10580 djs

src/managers/GuildChannelManager.js

@@ -298,7 +298,7 @@ class GuildChannelManager extends CachedManager {
 
     if (data.lockPermissions) {
       if (parentId) {
-        const newParent = this.guild.channels.cache.get(parentId);
+        const newParent = this.cache.get(parentId);
         if (newParent?.type === 'GUILD_CATEGORY') {
           permission_overwrites = newParent.permissionOverwrites.cache.map(o =>
             PermissionOverwrites.resolve(o, this.guild),

src/managers/GuildMemberManager.js

@@ -470,7 +470,7 @@ class GuildMemberManager extends CachedManager {
    * @returns {Promise<GuildMember|User|Snowflake>}
    */
   async addRole(user, role, reason) {
-    const userId = this.guild.members.resolveId(user);
+    const userId = this.resolveId(user);
     const roleId = this.guild.roles.resolveId(role);
 
     await this.client.api.guilds(this.guild.id).members(userId).roles(roleId).put({ reason });
@@ -486,7 +486,7 @@ class GuildMemberManager extends CachedManager {
    * @returns {Promise<GuildMember|User|Snowflake>}
    */
   async removeRole(user, role, reason) {
-    const userId = this.guild.members.resolveId(user);
+    const userId = this.resolveId(user);
     const roleId = this.guild.roles.resolveId(role);
 
     await this.client.api.guilds(this.guild.id).members(userId).roles(roleId).delete({ reason });

src/managers/GuildScheduledEventManager.js

@@ -174,10 +174,7 @@ class GuildScheduledEventManager extends CachedManager {
 
     return data.reduce(
       (coll, rawGuildScheduledEventData) =>
-        coll.set(
-          rawGuildScheduledEventData.id,
-          this.guild.scheduledEvents._add(rawGuildScheduledEventData, options.cache),
-        ),
+        coll.set(rawGuildScheduledEventData.id, this._add(rawGuildScheduledEventData, options.cache)),
       new Collection(),
     );
   }